public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [PATCH kernel-helper] proxmox-boot: add memtest86 as entry to systemd-boot
@ 2026-02-25 18:35 Stoiko Ivanov
  2026-02-25 18:39 ` Stoiko Ivanov
                   ` (3 more replies)
  0 siblings, 4 replies; 7+ messages in thread
From: Stoiko Ivanov @ 2026-02-25 18:35 UTC (permalink / raw)
  To: pve-devel

memtest86+ ships a config-snippet for grub configuration, and is thus
present on installations using grub (although currently not functional
when secure-boot is enabled).

adding an equivalent entry for memtest86+ on systemd-booted systems
seems like an improvment and a step to having similar functionality in
our different boot-loader setups.

Tested by installing proxmox-kernel-helper with this patch and running
proxmox-boot-tool reinit, followed by rebooting into memtest86+ on a
systemd-booted system.

Suggested-by: Daniel Herzig <d.herzig@proxmox.com>
Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
---
not 100% sure if it's worth adding, but both Daniel and I thought this might
exist and I remember missing it once on a host of mine

 src/bin/proxmox-boot-tool | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/src/bin/proxmox-boot-tool b/src/bin/proxmox-boot-tool
index 95d699d..b785c7d 100755
--- a/src/bin/proxmox-boot-tool
+++ b/src/bin/proxmox-boot-tool
@@ -196,6 +196,17 @@ init_bootloader() {
 			echo "timeout 3" > "$esp_mp/$PMX_LOADER_CONF.tmp"
 			echo "default proxmox-*" >> "$esp_mp/$PMX_LOADER_CONF.tmp"
 			mv "$esp_mp/$PMX_LOADER_CONF.tmp" "$esp_mp/$PMX_LOADER_CONF"
+			memtest=memtest86+x64.efi
+			memtest_conf="$esp_mp/loader/entries/$memtest.conf"
+			if [ -f "/boot/$memtest" ]; then
+				echo "Adding $memtest .."
+				cp "/boot/$memtest" "$esp_mp/EFI/"
+				cat > "$memtest_conf.tmp" <<- EOF
+					title Memory test ($memtest)
+					efi   /EFI/$memtest
+				EOF
+				mv "$memtest_conf.tmp" "$memtest_conf"
+			fi
 		fi
 	else
 		echo "Installing grub i386-pc target.."
-- 
2.47.3





^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH kernel-helper] proxmox-boot: add memtest86 as entry to systemd-boot
  2026-02-25 18:35 [PATCH kernel-helper] proxmox-boot: add memtest86 as entry to systemd-boot Stoiko Ivanov
@ 2026-02-25 18:39 ` Stoiko Ivanov
  2026-02-26 12:47 ` Hannes Laimer
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 7+ messages in thread
From: Stoiko Ivanov @ 2026-02-25 18:39 UTC (permalink / raw)
  To: pve-devel

On Wed, 25 Feb 2026 19:35:03 +0100
Stoiko Ivanov <s.ivanov@proxmox.com> wrote:

> memtest86+ ships a config-snippet for grub configuration, and is thus
> present on installations using grub (although currently not functional
> when secure-boot is enabled).
> 
> adding an equivalent entry for memtest86+ on systemd-booted systems
> seems like an improvment and a step to having similar functionality in
> our different boot-loader setups.
> 
> Tested by installing proxmox-kernel-helper with this patch and running
> proxmox-boot-tool reinit, followed by rebooting into memtest86+ on a
> systemd-booted system.
forgot to add a reference to:
https://uapi-group.org/specifications/specs/boot_loader_specification/
(as it took me a short while to find where the entries syntax is defined)


> 
> Suggested-by: Daniel Herzig <d.herzig@proxmox.com>
> Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
> ---
> not 100% sure if it's worth adding, but both Daniel and I thought this might
> exist and I remember missing it once on a host of mine
> 
>  src/bin/proxmox-boot-tool | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/src/bin/proxmox-boot-tool b/src/bin/proxmox-boot-tool
> index 95d699d..b785c7d 100755
> --- a/src/bin/proxmox-boot-tool
> +++ b/src/bin/proxmox-boot-tool
> @@ -196,6 +196,17 @@ init_bootloader() {
>  			echo "timeout 3" > "$esp_mp/$PMX_LOADER_CONF.tmp"
>  			echo "default proxmox-*" >> "$esp_mp/$PMX_LOADER_CONF.tmp"
>  			mv "$esp_mp/$PMX_LOADER_CONF.tmp" "$esp_mp/$PMX_LOADER_CONF"
> +			memtest=memtest86+x64.efi
> +			memtest_conf="$esp_mp/loader/entries/$memtest.conf"
> +			if [ -f "/boot/$memtest" ]; then
> +				echo "Adding $memtest .."
> +				cp "/boot/$memtest" "$esp_mp/EFI/"
> +				cat > "$memtest_conf.tmp" <<- EOF
> +					title Memory test ($memtest)
> +					efi   /EFI/$memtest
> +				EOF
> +				mv "$memtest_conf.tmp" "$memtest_conf"
> +			fi
>  		fi
>  	else
>  		echo "Installing grub i386-pc target.."





^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH kernel-helper] proxmox-boot: add memtest86 as entry to systemd-boot
  2026-02-25 18:35 [PATCH kernel-helper] proxmox-boot: add memtest86 as entry to systemd-boot Stoiko Ivanov
  2026-02-25 18:39 ` Stoiko Ivanov
@ 2026-02-26 12:47 ` Hannes Laimer
  2026-02-26 13:39 ` Daniel Herzig
  2026-02-26 14:01 ` Laurențiu Leahu-Vlăducu
  3 siblings, 0 replies; 7+ messages in thread
From: Hannes Laimer @ 2026-02-26 12:47 UTC (permalink / raw)
  To: Stoiko Ivanov, pve-devel

does add the entry and memtest works, consider this

Tested-by: Hannes Laimer <h.laimer@proxmox.com>

On 2026-02-25 19:37, Stoiko Ivanov wrote:
> memtest86+ ships a config-snippet for grub configuration, and is thus
> present on installations using grub (although currently not functional
> when secure-boot is enabled).
> 
> adding an equivalent entry for memtest86+ on systemd-booted systems
> seems like an improvment and a step to having similar functionality in
> our different boot-loader setups.
> 
> Tested by installing proxmox-kernel-helper with this patch and running
> proxmox-boot-tool reinit, followed by rebooting into memtest86+ on a
> systemd-booted system.
> 
> Suggested-by: Daniel Herzig <d.herzig@proxmox.com>
> Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
> ---
> not 100% sure if it's worth adding, but both Daniel and I thought this might
> exist and I remember missing it once on a host of mine
> 
>  src/bin/proxmox-boot-tool | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/src/bin/proxmox-boot-tool b/src/bin/proxmox-boot-tool
> index 95d699d..b785c7d 100755
> --- a/src/bin/proxmox-boot-tool
> +++ b/src/bin/proxmox-boot-tool
> @@ -196,6 +196,17 @@ init_bootloader() {
>  			echo "timeout 3" > "$esp_mp/$PMX_LOADER_CONF.tmp"
>  			echo "default proxmox-*" >> "$esp_mp/$PMX_LOADER_CONF.tmp"
>  			mv "$esp_mp/$PMX_LOADER_CONF.tmp" "$esp_mp/$PMX_LOADER_CONF"
> +			memtest=memtest86+x64.efi
> +			memtest_conf="$esp_mp/loader/entries/$memtest.conf"
> +			if [ -f "/boot/$memtest" ]; then
> +				echo "Adding $memtest .."
> +				cp "/boot/$memtest" "$esp_mp/EFI/"
> +				cat > "$memtest_conf.tmp" <<- EOF
> +					title Memory test ($memtest)
> +					efi   /EFI/$memtest
> +				EOF
> +				mv "$memtest_conf.tmp" "$memtest_conf"
> +			fi
>  		fi
>  	else
>  		echo "Installing grub i386-pc target.."





^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH kernel-helper] proxmox-boot: add memtest86 as entry to systemd-boot
  2026-02-25 18:35 [PATCH kernel-helper] proxmox-boot: add memtest86 as entry to systemd-boot Stoiko Ivanov
  2026-02-25 18:39 ` Stoiko Ivanov
  2026-02-26 12:47 ` Hannes Laimer
@ 2026-02-26 13:39 ` Daniel Herzig
  2026-02-27  8:00   ` Daniel Herzig
  2026-02-26 14:01 ` Laurențiu Leahu-Vlăducu
  3 siblings, 1 reply; 7+ messages in thread
From: Daniel Herzig @ 2026-02-26 13:39 UTC (permalink / raw)
  To: Stoiko Ivanov, pve-devel

thanks -- works as expected for my RAIDz1 2-disk setup!

Although not in the scope of this patch, I want to note that the entry 
is not created for ZFS GRUB installations (be it on legacy non-EFI, or 
secure-boot EFI), as opposed to LVM GRUB installations.

Tested-by: Daniel Herzig<d.herzig@proxmox.com>

On 2/25/26 7:37 PM, Stoiko Ivanov wrote:
> memtest86+ ships a config-snippet for grub configuration, and is thus
> present on installations using grub (although currently not functional
> when secure-boot is enabled).
>
> adding an equivalent entry for memtest86+ on systemd-booted systems
> seems like an improvment and a step to having similar functionality in
> our different boot-loader setups.
>
> Tested by installing proxmox-kernel-helper with this patch and running
> proxmox-boot-tool reinit, followed by rebooting into memtest86+ on a
> systemd-booted system.
>
> Suggested-by: Daniel Herzig <d.herzig@proxmox.com>
> Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
> ---
> not 100% sure if it's worth adding, but both Daniel and I thought this might
> exist and I remember missing it once on a host of mine
>
>   src/bin/proxmox-boot-tool | 11 +++++++++++
>   1 file changed, 11 insertions(+)
>
> diff --git a/src/bin/proxmox-boot-tool b/src/bin/proxmox-boot-tool
> index 95d699d..b785c7d 100755
> --- a/src/bin/proxmox-boot-tool
> +++ b/src/bin/proxmox-boot-tool
> @@ -196,6 +196,17 @@ init_bootloader() {
>   			echo "timeout 3" > "$esp_mp/$PMX_LOADER_CONF.tmp"
>   			echo "default proxmox-*" >> "$esp_mp/$PMX_LOADER_CONF.tmp"
>   			mv "$esp_mp/$PMX_LOADER_CONF.tmp" "$esp_mp/$PMX_LOADER_CONF"
> +			memtest=memtest86+x64.efi
> +			memtest_conf="$esp_mp/loader/entries/$memtest.conf"
> +			if [ -f "/boot/$memtest" ]; then
> +				echo "Adding $memtest .."
> +				cp "/boot/$memtest" "$esp_mp/EFI/"
> +				cat > "$memtest_conf.tmp" <<- EOF
> +					title Memory test ($memtest)
> +					efi   /EFI/$memtest
> +				EOF
> +				mv "$memtest_conf.tmp" "$memtest_conf"
> +			fi
>   		fi
>   	else
>   		echo "Installing grub i386-pc target.."




^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH kernel-helper] proxmox-boot: add memtest86 as entry to systemd-boot
  2026-02-25 18:35 [PATCH kernel-helper] proxmox-boot: add memtest86 as entry to systemd-boot Stoiko Ivanov
                   ` (2 preceding siblings ...)
  2026-02-26 13:39 ` Daniel Herzig
@ 2026-02-26 14:01 ` Laurențiu Leahu-Vlăducu
  3 siblings, 0 replies; 7+ messages in thread
From: Laurențiu Leahu-Vlăducu @ 2026-02-26 14:01 UTC (permalink / raw)
  To: pve-devel

Thanks for working on this! This is certainly something that quite a few 
people have asked for over time.

For reference:
- this has been asked for on our forum [0]
- this patch fixes issue #7223 - see [1]



[0] https://forum.proxmox.com/threads/memtest86.163802/
[1] https://bugzilla.proxmox.com/show_bug.cgi?id=7223



On 25.02.26 19:37, Stoiko Ivanov wrote:
> memtest86+ ships a config-snippet for grub configuration, and is thus
> present on installations using grub (although currently not functional
> when secure-boot is enabled).
> 
> adding an equivalent entry for memtest86+ on systemd-booted systems
> seems like an improvment and a step to having similar functionality in
> our different boot-loader setups.
> 
> Tested by installing proxmox-kernel-helper with this patch and running
> proxmox-boot-tool reinit, followed by rebooting into memtest86+ on a
> systemd-booted system.
> 
> Suggested-by: Daniel Herzig <d.herzig@proxmox.com>
> Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
> ---
> not 100% sure if it's worth adding, but both Daniel and I thought this might
> exist and I remember missing it once on a host of mine
> 
>   src/bin/proxmox-boot-tool | 11 +++++++++++
>   1 file changed, 11 insertions(+)
> 
> diff --git a/src/bin/proxmox-boot-tool b/src/bin/proxmox-boot-tool
> index 95d699d..b785c7d 100755
> --- a/src/bin/proxmox-boot-tool
> +++ b/src/bin/proxmox-boot-tool
> @@ -196,6 +196,17 @@ init_bootloader() {
>   			echo "timeout 3" > "$esp_mp/$PMX_LOADER_CONF.tmp"
>   			echo "default proxmox-*" >> "$esp_mp/$PMX_LOADER_CONF.tmp"
>   			mv "$esp_mp/$PMX_LOADER_CONF.tmp" "$esp_mp/$PMX_LOADER_CONF"
> +			memtest=memtest86+x64.efi
> +			memtest_conf="$esp_mp/loader/entries/$memtest.conf"
> +			if [ -f "/boot/$memtest" ]; then
> +				echo "Adding $memtest .."
> +				cp "/boot/$memtest" "$esp_mp/EFI/"
> +				cat > "$memtest_conf.tmp" <<- EOF
> +					title Memory test ($memtest)
> +					efi   /EFI/$memtest
> +				EOF
> +				mv "$memtest_conf.tmp" "$memtest_conf"
> +			fi
>   		fi
>   	else
>   		echo "Installing grub i386-pc target.."





^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH kernel-helper] proxmox-boot: add memtest86 as entry to systemd-boot
  2026-02-26 13:39 ` Daniel Herzig
@ 2026-02-27  8:00   ` Daniel Herzig
  2026-02-27 14:47     ` superseded: " Stoiko Ivanov
  0 siblings, 1 reply; 7+ messages in thread
From: Daniel Herzig @ 2026-02-27  8:00 UTC (permalink / raw)
  To: Stoiko Ivanov, pve-devel


On 2/26/26 2:39 PM, Daniel Herzig wrote:
> thanks -- works as expected for my RAIDz1 2-disk setup!

For if anyone wonders -- there's a 'z' that sneaked in here. I initially 
tested against a ZFS RAID 1 two-disk mirror.

Just to make sure, I now also tested against a ZFS RAIDz-1 three-disk 
installation. As expected, the patch works fine for that as well.


>
> Although not in the scope of this patch, I want to note that the entry 
> is not created for ZFS GRUB installations (be it on legacy non-EFI, or 
> secure-boot EFI), as opposed to LVM GRUB installations.
>
> Tested-by: Daniel Herzig<d.herzig@proxmox.com>
>
> On 2/25/26 7:37 PM, Stoiko Ivanov wrote:
>> memtest86+ ships a config-snippet for grub configuration, and is thus
>> present on installations using grub (although currently not functional
>> when secure-boot is enabled).
>>
>> adding an equivalent entry for memtest86+ on systemd-booted systems
>> seems like an improvment and a step to having similar functionality in
>> our different boot-loader setups.
>>
>> Tested by installing proxmox-kernel-helper with this patch and running
>> proxmox-boot-tool reinit, followed by rebooting into memtest86+ on a
>> systemd-booted system.
>>
>> Suggested-by: Daniel Herzig <d.herzig@proxmox.com>
>> Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
>> ---
>> not 100% sure if it's worth adding, but both Daniel and I thought 
>> this might
>> exist and I remember missing it once on a host of mine
>>
>>   src/bin/proxmox-boot-tool | 11 +++++++++++
>>   1 file changed, 11 insertions(+)
>>
>> diff --git a/src/bin/proxmox-boot-tool b/src/bin/proxmox-boot-tool
>> index 95d699d..b785c7d 100755
>> --- a/src/bin/proxmox-boot-tool
>> +++ b/src/bin/proxmox-boot-tool
>> @@ -196,6 +196,17 @@ init_bootloader() {
>>               echo "timeout 3" > "$esp_mp/$PMX_LOADER_CONF.tmp"
>>               echo "default proxmox-*" >> "$esp_mp/$PMX_LOADER_CONF.tmp"
>>               mv "$esp_mp/$PMX_LOADER_CONF.tmp" 
>> "$esp_mp/$PMX_LOADER_CONF"
>> +            memtest=memtest86+x64.efi
>> +            memtest_conf="$esp_mp/loader/entries/$memtest.conf"
>> +            if [ -f "/boot/$memtest" ]; then
>> +                echo "Adding $memtest .."
>> +                cp "/boot/$memtest" "$esp_mp/EFI/"
>> +                cat > "$memtest_conf.tmp" <<- EOF
>> +                    title Memory test ($memtest)
>> +                    efi   /EFI/$memtest
>> +                EOF
>> +                mv "$memtest_conf.tmp" "$memtest_conf"
>> +            fi
>>           fi
>>       else
>>           echo "Installing grub i386-pc target.."
>
>
>
>




^ permalink raw reply	[flat|nested] 7+ messages in thread

* superseded: [PATCH kernel-helper] proxmox-boot: add memtest86 as entry to systemd-boot
  2026-02-27  8:00   ` Daniel Herzig
@ 2026-02-27 14:47     ` Stoiko Ivanov
  0 siblings, 0 replies; 7+ messages in thread
From: Stoiko Ivanov @ 2026-02-27 14:47 UTC (permalink / raw)
  To: pve-devel

On Fri, 27 Feb 2026 09:00:23 +0100
Daniel Herzig <d.herzig@proxmox.com> wrote:

> On 2/26/26 2:39 PM, Daniel Herzig wrote:
> > thanks -- works as expected for my RAIDz1 2-disk setup!  
> 
> For if anyone wonders -- there's a 'z' that sneaked in here. I initially 
> tested against a ZFS RAID 1 two-disk mirror.
> 
> Just to make sure, I now also tested against a ZFS RAIDz-1 three-disk 
> installation. As expected, the patch works fine for that as well.
> 
> 
> >
> > Although not in the scope of this patch, I want to note that the entry 
> > is not created for ZFS GRUB installations (be it on legacy non-EFI, or 
> > secure-boot EFI), as opposed to LVM GRUB installations.
> >
> > Tested-by: Daniel Herzig<d.herzig@proxmox.com>

Thank you all for testing this so quickly - sent a new version (with
bug-reference and grub-handling):
https://lore.proxmox.com/pve-devel/20260227144336.3029652-1-s.ivanov@proxmox.com/T/#u

> >
> > On 2/25/26 7:37 PM, Stoiko Ivanov wrote:  
> >> memtest86+ ships a config-snippet for grub configuration, and is thus
> >> present on installations using grub (although currently not functional
> >> when secure-boot is enabled).
> >>
> >> adding an equivalent entry for memtest86+ on systemd-booted systems
> >> seems like an improvment and a step to having similar functionality in
> >> our different boot-loader setups.
> >>
> >> Tested by installing proxmox-kernel-helper with this patch and running
> >> proxmox-boot-tool reinit, followed by rebooting into memtest86+ on a
> >> systemd-booted system.
> >>
> >> Suggested-by: Daniel Herzig <d.herzig@proxmox.com>
> >> Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
> >> ---
> >> not 100% sure if it's worth adding, but both Daniel and I thought 
> >> this might
> >> exist and I remember missing it once on a host of mine
> >>
> >>   src/bin/proxmox-boot-tool | 11 +++++++++++
> >>   1 file changed, 11 insertions(+)
> >>
> >> diff --git a/src/bin/proxmox-boot-tool b/src/bin/proxmox-boot-tool
> >> index 95d699d..b785c7d 100755
> >> --- a/src/bin/proxmox-boot-tool
> >> +++ b/src/bin/proxmox-boot-tool
> >> @@ -196,6 +196,17 @@ init_bootloader() {
> >>               echo "timeout 3" > "$esp_mp/$PMX_LOADER_CONF.tmp"
> >>               echo "default proxmox-*" >> "$esp_mp/$PMX_LOADER_CONF.tmp"
> >>               mv "$esp_mp/$PMX_LOADER_CONF.tmp" 
> >> "$esp_mp/$PMX_LOADER_CONF"
> >> +            memtest=memtest86+x64.efi
> >> +            memtest_conf="$esp_mp/loader/entries/$memtest.conf"
> >> +            if [ -f "/boot/$memtest" ]; then
> >> +                echo "Adding $memtest .."
> >> +                cp "/boot/$memtest" "$esp_mp/EFI/"
> >> +                cat > "$memtest_conf.tmp" <<- EOF
> >> +                    title Memory test ($memtest)
> >> +                    efi   /EFI/$memtest
> >> +                EOF
> >> +                mv "$memtest_conf.tmp" "$memtest_conf"
> >> +            fi
> >>           fi
> >>       else
> >>           echo "Installing grub i386-pc target.."  
> >
> >
> >
> >  





^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2026-02-27 14:46 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-02-25 18:35 [PATCH kernel-helper] proxmox-boot: add memtest86 as entry to systemd-boot Stoiko Ivanov
2026-02-25 18:39 ` Stoiko Ivanov
2026-02-26 12:47 ` Hannes Laimer
2026-02-26 13:39 ` Daniel Herzig
2026-02-27  8:00   ` Daniel Herzig
2026-02-27 14:47     ` superseded: " Stoiko Ivanov
2026-02-26 14:01 ` Laurențiu Leahu-Vlăducu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal