public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Maximiliano Sandoval <m.sandoval@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH storage 1/1] cifs: match smbversion description with docs
Date: Thu, 26 Feb 2026 15:43:14 +0100	[thread overview]
Message-ID: <20260226144316.451521-2-m.sandoval@proxmox.com> (raw)
In-Reply-To: <20260226144316.451521-1-m.sandoval@proxmox.com>

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
 src/PVE/Storage/CIFSPlugin.pm | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/src/PVE/Storage/CIFSPlugin.pm b/src/PVE/Storage/CIFSPlugin.pm
index 54f0f4e..665ce1f 100644
--- a/src/PVE/Storage/CIFSPlugin.pm
+++ b/src/PVE/Storage/CIFSPlugin.pm
@@ -147,9 +147,10 @@ sub properties {
             maxLength => 256,
         },
         smbversion => {
-            description =>
-                "SMB protocol version. 'default' if not set, negotiates the highest SMB2+"
-                . " version supported by both the client and server.",
+            description => "SMB protocol version.",
+            verbose_description => "SMB protocol version. When set to `default` or when unset,"
+                . " negotiates the highest SMB2+ version supported by both the client and server."
+                . " SMB1 is not supported due to security issues.",
             type => 'string',
             default => 'default',
             enum => ['default', '2.0', '2.1', '3', '3.0', '3.11'],
-- 
2.47.3





  reply	other threads:[~2026-02-26 14:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-26 14:43 [PATCH docs/storage 0/2] docs: match smbdescription at pve-docs and pve-storage Maximiliano Sandoval
2026-02-26 14:43 ` Maximiliano Sandoval [this message]
2026-02-26 14:43 ` [PATCH docs 1/1] docs: cifs: match smbversion docs with pve-storage Maximiliano Sandoval

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260226144316.451521-2-m.sandoval@proxmox.com \
    --to=m.sandoval@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal