public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Stoiko Ivanov <s.ivanov@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: Re: [PATCH kernel-helper] proxmox-boot: add memtest86 as entry to systemd-boot
Date: Wed, 25 Feb 2026 19:39:04 +0100	[thread overview]
Message-ID: <20260225193904.325f255d@rosa.proxmox.com> (raw)
In-Reply-To: <20260225183621.201783-1-s.ivanov@proxmox.com>

On Wed, 25 Feb 2026 19:35:03 +0100
Stoiko Ivanov <s.ivanov@proxmox.com> wrote:

> memtest86+ ships a config-snippet for grub configuration, and is thus
> present on installations using grub (although currently not functional
> when secure-boot is enabled).
> 
> adding an equivalent entry for memtest86+ on systemd-booted systems
> seems like an improvment and a step to having similar functionality in
> our different boot-loader setups.
> 
> Tested by installing proxmox-kernel-helper with this patch and running
> proxmox-boot-tool reinit, followed by rebooting into memtest86+ on a
> systemd-booted system.
forgot to add a reference to:
https://uapi-group.org/specifications/specs/boot_loader_specification/
(as it took me a short while to find where the entries syntax is defined)


> 
> Suggested-by: Daniel Herzig <d.herzig@proxmox.com>
> Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
> ---
> not 100% sure if it's worth adding, but both Daniel and I thought this might
> exist and I remember missing it once on a host of mine
> 
>  src/bin/proxmox-boot-tool | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/src/bin/proxmox-boot-tool b/src/bin/proxmox-boot-tool
> index 95d699d..b785c7d 100755
> --- a/src/bin/proxmox-boot-tool
> +++ b/src/bin/proxmox-boot-tool
> @@ -196,6 +196,17 @@ init_bootloader() {
>  			echo "timeout 3" > "$esp_mp/$PMX_LOADER_CONF.tmp"
>  			echo "default proxmox-*" >> "$esp_mp/$PMX_LOADER_CONF.tmp"
>  			mv "$esp_mp/$PMX_LOADER_CONF.tmp" "$esp_mp/$PMX_LOADER_CONF"
> +			memtest=memtest86+x64.efi
> +			memtest_conf="$esp_mp/loader/entries/$memtest.conf"
> +			if [ -f "/boot/$memtest" ]; then
> +				echo "Adding $memtest .."
> +				cp "/boot/$memtest" "$esp_mp/EFI/"
> +				cat > "$memtest_conf.tmp" <<- EOF
> +					title Memory test ($memtest)
> +					efi   /EFI/$memtest
> +				EOF
> +				mv "$memtest_conf.tmp" "$memtest_conf"
> +			fi
>  		fi
>  	else
>  		echo "Installing grub i386-pc target.."





  reply	other threads:[~2026-02-25 18:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-25 18:35 Stoiko Ivanov
2026-02-25 18:39 ` Stoiko Ivanov [this message]
2026-02-26 12:47 ` Hannes Laimer
2026-02-26 13:39 ` Daniel Herzig
2026-02-26 14:01 ` Laurențiu Leahu-Vlăducu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260225193904.325f255d@rosa.proxmox.com \
    --to=s.ivanov@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal