From: Maximiliano Sandoval <m.sandoval@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH manager 5/7] ui: qga: add checkbox for guest-fsfreeze
Date: Wed, 25 Feb 2026 16:45:44 +0100 [thread overview]
Message-ID: <20260225154614.681858-6-m.sandoval@proxmox.com> (raw)
In-Reply-To: <20260225154614.681858-1-m.sandoval@proxmox.com>
We re-use the same components from the 'freeze-fs-on-backup' checkbox
but without referencing that this only affects backups.
Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
www/manager6/form/AgentFeatureSelector.js | 28 +++++++++++++++++++++++
1 file changed, 28 insertions(+)
diff --git a/www/manager6/form/AgentFeatureSelector.js b/www/manager6/form/AgentFeatureSelector.js
index e7fa929c..a3dda630 100644
--- a/www/manager6/form/AgentFeatureSelector.js
+++ b/www/manager6/form/AgentFeatureSelector.js
@@ -21,6 +21,28 @@ Ext.define('PVE.form.AgentFeatureSelector', {
},
disabled: true,
},
+ {
+ xtype: 'proxmoxcheckbox',
+ boxLabel: gettext('Freeze/thaw guest filesystems for consistency'),
+ name: 'guest-fsfreeze',
+ reference: 'guest_fsfreeze',
+ bind: {
+ disabled: '{!enabled.checked}',
+ },
+ disabled: true,
+ uncheckedValue: '0',
+ defaultValue: '1',
+ },
+ {
+ xtype: 'displayfield',
+ userCls: 'pmx-hint',
+ value: gettext(
+ 'Freeze/thaw for guest filesystems disabled. This can lead to inconsistent disk images.',
+ ),
+ bind: {
+ hidden: '{guest_fsfreeze.checked}',
+ },
+ },
{
xtype: 'displayfield',
userCls: 'pmx-hint',
@@ -73,6 +95,9 @@ Ext.define('PVE.form.AgentFeatureSelector', {
if (PVE.Parser.parseBoolean(values['freeze-fs-on-backup'])) {
delete values['freeze-fs-on-backup'];
}
+ if (PVE.Parser.parseBoolean(values['guest-fsfreeze'])) {
+ delete values['guest-fsfreeze'];
+ }
const agentstr = PVE.Parser.printPropertyString(values, 'enabled');
return { agent: agentstr };
@@ -83,6 +108,9 @@ Ext.define('PVE.form.AgentFeatureSelector', {
if (!Ext.isDefined(res['freeze-fs-on-backup'])) {
res['freeze-fs-on-backup'] = 1;
}
+ if (!Ext.isDefined(res['guest-fsfreeze'])) {
+ res['guest-fsfreeze'] = 1;
+ }
this.callParent([res]);
},
--
2.47.3
next prev parent reply other threads:[~2026-02-25 15:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-25 15:45 [PATCH manager 0/7] " Maximiliano Sandoval
2026-02-25 15:45 ` [PATCH manager 1/7] ui: utils: support guest-fsfreeze at render_qga_features Maximiliano Sandoval
2026-02-25 15:45 ` [PATCH manager 2/7] ui: qga: merge translatable string Maximiliano Sandoval
2026-02-25 15:45 ` [PATCH manager 3/7] ui: qga: move freeze-fs-on-backup to advanced opts Maximiliano Sandoval
2026-02-25 15:45 ` [PATCH manager 4/7] ui: qga: note that freeze-fs-on-backup is deprecated Maximiliano Sandoval
2026-02-25 15:45 ` Maximiliano Sandoval [this message]
2026-02-25 15:45 ` [PATCH manager 6/7] ui: qga: call parameter me instead of this Maximiliano Sandoval
2026-02-25 15:45 ` [PATCH manager 7/7] ui: qga: hide freeze-fs-on-backup check if undefined Maximiliano Sandoval
2026-02-25 16:03 ` [PATCH manager 0/7] ui: qga: add checkbox for guest-fsfreeze Maximiliano Sandoval
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260225154614.681858-6-m.sandoval@proxmox.com \
--to=m.sandoval@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox