[PATCH-SERIES qemu-server/guest-common/container v2 00/14] migration: strict config check for intra-cluster migration

[Fiona Ebner <f.ebner@proxmox.com>]

Changes in v2:
* add patches for container
* log when skipping strict configuration check

For remote migration, we already check that the config can be parsed
on the target. Do the same for intra-cluster migration, to avoid
issues like [0] for future new settings, with settings being
unexpectedly ignored on the target, and in the case of qemu-server
even relatively silently dropped (there are warnings in the target's
system logs). In case of containers, an example is migrating a
container with a mountpoint with 'keepattrs' to a node with a too old
pve-container version, resulting in the mountpoint not being mounted
on the target.

The first few patches for each repository are cleanups/tiny
improvements that would be nice to have in any case.

Unfortunately, before patch "qm: mtunnel: reply when a command is
unknown", when a command is unknown, mtunnel did not reply at all.
Therefore, this delays VM backwards migrations to qemu-server versions
less than the next bumped version (at the time of this writing
expected to be 9.1.5) by 3 seconds.

I opted for 3 seconds, since config parsing should be very quick and
5 seconds would still be very noticeable for a bulk migration of VMs
on a shared storage with a fast network. Right now, the option won't
help anyways, only once we add a new config option (at which point
we could bump it to 5 seconds).

For containers, an 'mtunnel' endpoint is added and changes to stderr
handling for the tunnel are useful, see guest-common patch "tunnel:
redirect stderr to log function".

[0]: https://bugzilla.proxmox.com/show_bug.cgi?id=7341

Dependency bump pve-container -> guest-common needed!

qemu-server:

Fiona Ebner (6):
  d/control: bump versioned build dependency for libpve-common-perl to
    9.0.12
  tests: migration: get rid of mocking for removed
    PVE::QemuMigrate::read_tunnel()
  qm: mtunnel: avoid using deprecated check_running() helper
  mtunnel: add 'conf' command to do strict configuration parsing
  qm: mtunnel: reply when a command is unknown
  migration: intra-cluster: check config can be parsed on target node

 debian/control                            |  2 +-
 src/PVE/API2/Qemu.pm                      |  4 +++-
 src/PVE/CLI/qm.pm                         | 21 +++++++++++++++---
 src/PVE/QemuMigrate.pm                    | 27 +++++++++++++++++++++++
 src/test/MigrationTest/QemuMigrateMock.pm | 14 ++++++++----
 5 files changed, 59 insertions(+), 9 deletions(-)


guest-common:

Fiona Ebner (3):
  tunnel: add missing IO::File module import
  tunnel: end module with true value as recommended by perlcritic
  tunnel: redirect stderr to log function

 src/PVE/Tunnel.pm | 20 +++++++++++++++++---
 1 file changed, 17 insertions(+), 3 deletions(-)


container:

Fiona Ebner (5):
  pct: add missing module imports and group according to style guide
  migrate: add missing module imports
  pct: introduce mtunnel command
  d/control: bump versioned build dependency for libpve-common-perl to
    9.0.12
  migration: intra-cluster: check config can be parsed on target node

 debian/control         |  2 +-
 src/PVE/API2/LXC.pm    | 11 ++++++++
 src/PVE/CLI/pct.pm     | 64 +++++++++++++++++++++++++++++++++++++++++-
 src/PVE/LXC/Migrate.pm | 41 +++++++++++++++++++++++++++
 4 files changed, 116 insertions(+), 2 deletions(-)


Summary over all repositories:
  10 files changed, 192 insertions(+), 14 deletions(-)

-- 
Generated by git-murpp 0.5.0