public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH-SERIES qemu-server 0/6] migration: strict config check for intra-cluster migration
Date: Fri, 20 Feb 2026 14:36:08 +0100	[thread overview]
Message-ID: <20260220133911.135593-1-f.ebner@proxmox.com> (raw)

For remote migration, we already check that the config can be parsed
on the target. Do the same for intra-cluster migration, to avoid
issues like [0] for future new settings, with lines being unexpectedly
and relatively silently dropped (there are warnings in the target's
system logs).

The first few patches are cleanups/tiny improvements that would be
nice to have in any case.

Unfortunately, before patch "qm: mtunnel: reply when a command is
unknown", when a command is unknown, mtunnel did not reply at all.
Therefore, this delays backwards migrations to qemu-server versions
less than the next bumped version (at the time of this writing
expected to be 9.1.5) by 3 seconds.

I opted for 3 seconds, since config parsing should be very quick and
5 seconds would still be very noticeable for a bulk migration of VMs
on a shared storage with a fast network. Right now, the option won't
help anyways, only once we add a new config option (at which point
we could bump it to 5 seconds).

[0]: https://bugzilla.proxmox.com/show_bug.cgi?id=7341

qemu-server:

Fiona Ebner (6):
  d/control: bump versioned build dependency for libpve-common-perl to
    9.0.12
  tests: migration: get rid of mocking for removed
    PVE::QemuMigrate::read_tunnel()
  qm: mtunnel: avoid using deprecated check_running() helper
  mtunnel: add 'conf' command to do strict configuration parsing
  qm: mtunnel: reply when a command is unknown
  migration: intra-cluster: check config can be parsed on target node

 debian/control                            |  2 +-
 src/PVE/API2/Qemu.pm                      |  4 +++-
 src/PVE/CLI/qm.pm                         | 21 ++++++++++++++++++---
 src/PVE/QemuMigrate.pm                    | 23 +++++++++++++++++++++++
 src/test/MigrationTest/QemuMigrateMock.pm | 14 ++++++++++----
 5 files changed, 55 insertions(+), 9 deletions(-)


Summary over all repositories:
  5 files changed, 55 insertions(+), 9 deletions(-)

-- 
Generated by git-murpp 0.5.0




             reply	other threads:[~2026-02-20 13:39 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-20 13:36 Fiona Ebner [this message]
2026-02-20 13:36 ` [PATCH qemu-server 1/6] d/control: bump versioned build dependency for libpve-common-perl to 9.0.12 Fiona Ebner
2026-02-20 13:36 ` [PATCH qemu-server 2/6] tests: migration: get rid of mocking for removed PVE::QemuMigrate::read_tunnel() Fiona Ebner
2026-02-20 13:36 ` [PATCH qemu-server 3/6] qm: mtunnel: avoid using deprecated check_running() helper Fiona Ebner
2026-02-20 13:36 ` [PATCH qemu-server 4/6] mtunnel: add 'conf' command to do strict configuration parsing Fiona Ebner
2026-02-20 13:36 ` [PATCH qemu-server 5/6] qm: mtunnel: reply when a command is unknown Fiona Ebner
2026-02-20 13:36 ` [PATCH qemu-server 6/6] migration: intra-cluster: check config can be parsed on target node Fiona Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260220133911.135593-1-f.ebner@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal