public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Gabriel Goller <g.goller@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH pve-network v2 2/2] sdn: controllers: rename isis domain to fabric_id
Date: Thu, 19 Feb 2026 16:25:27 +0100	[thread overview]
Message-ID: <20260219152544.427439-8-g.goller@proxmox.com> (raw)
In-Reply-To: <20260219152544.427439-1-g.goller@proxmox.com>

Rename the "domain" property to "fabric_id" in the ISIS controller to
align with the ISIS fabric naming convention and enable sharing of
proxmox-frr ISIS types between both components.

The ISIS fabric and ISIS controller share basic configuration options,
but previously used different property names ("fabric_id" vs "domain").
Since fabrics are hardcoded to use "fabric_id", standardize the
controller to use the same naming.

This change is backwards compatible as:
1) The template series has not yet been merged and will likely merge
   alongside this series
2) It is unlikely that libpve-rs-perl and libpve-network-perl would
   become out of sync

Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
---
 src/PVE/Network/SDN/Controllers/IsisPlugin.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/PVE/Network/SDN/Controllers/IsisPlugin.pm b/src/PVE/Network/SDN/Controllers/IsisPlugin.pm
index 454bdda6d316..81aef2de7e24 100644
--- a/src/PVE/Network/SDN/Controllers/IsisPlugin.pm
+++ b/src/PVE/Network/SDN/Controllers/IsisPlugin.pm
@@ -87,7 +87,7 @@ sub generate_frr_config {
     for my $iface (sort @ifaces) {
         my $iface_name = $altnames->{$iface} // $iface;
         $config->{frr}->{isis}->{interfaces}->{$iface_name} //= {};
-        $config->{frr}->{isis}->{interfaces}->{$iface_name}->{domain} = $isis_domain;
+        $config->{frr}->{isis}->{interfaces}->{$iface_name}->{fabric_id} = $isis_domain;
         $config->{frr}->{isis}->{interfaces}->{$iface_name}->{is_ipv4} = 1;
         $config->{frr}->{isis}->{interfaces}->{$iface_name}->{is_ipv6} = 0;
     }
-- 
2.47.3





  parent reply	other threads:[~2026-02-19 15:25 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-19 15:25 [PATCH docs/gui-tests/manager/network/proxmox{-ve-rs,-perl-rs} v2 00/11] Add IS-IS protocol to fabrics Gabriel Goller
2026-02-19 15:25 ` [PATCH proxmox-ve-rs v2 1/3] frr: add fabric properties to ISIS types and rename domain Gabriel Goller
2026-02-19 15:25 ` [PATCH proxmox-ve-rs v2 2/3] ve-config: add IS-IS fabric config parsing and frr config generation Gabriel Goller
2026-02-19 15:25 ` [PATCH proxmox-ve-rs v2 3/3] ve-config: add integration tests for IS-IS fabrics Gabriel Goller
2026-02-19 15:25 ` [PATCH proxmox-perl-rs v2 1/2] pve-rs: fabrics: add IS-IS protocol ifupdown config generation Gabriel Goller
2026-02-19 15:25 ` [PATCH proxmox-perl-rs v2 2/2] sdn: add IS-IS fabric status reporting Gabriel Goller
2026-02-19 15:25 ` [PATCH pve-network v2 1/2] fabrics: add IS-IS api types Gabriel Goller
2026-02-19 15:25 ` Gabriel Goller [this message]
2026-02-19 15:25 ` [PATCH pve-manager v2 1/2] fabrics: add IS-IS panels Gabriel Goller
2026-02-19 15:25 ` [PATCH pve-manager v2 2/2] sdn: add warning about IS-IS controller deprecation Gabriel Goller
2026-02-19 15:25 ` [PATCH pve-docs v2 1/1] sdn: add section about IS-IS fabric Gabriel Goller
2026-02-19 15:25 ` [PATCH pve-gui-tests v2 1/1] fabrics: add screenshots for IS-IS fabric and nodes Gabriel Goller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260219152544.427439-8-g.goller@proxmox.com \
    --to=g.goller@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal