public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Lukas Sichert <l.sichert@proxmox.com>
To: pve-devel@lists.proxmox.com
Cc: Lukas Sichert <l.sichert@proxmox.com>
Subject: [PATCH manager] ui: download iso: trim filename to correctly detect file extension
Date: Tue, 17 Feb 2026 13:26:50 +0100	[thread overview]
Message-ID: <20260217122650.52268-1-l.sichert@proxmox.com> (raw)

When downloading an ISO from a URL without querying for the
metadata, one can set a custom filename. If this filename is trailed by
blank spaces, trying to download will result in the error:
'Parameter verification failed. (400) filename: wrong file extension'

To correctly detect file extensions, adjust the getSubmitValue function
for this specific textfield to trim the filename for blankspaces.

Signed-off-by: Lukas Sichert <l.sichert@proxmox.com>
---
 www/manager6/window/DownloadUrlToStorage.js | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/www/manager6/window/DownloadUrlToStorage.js b/www/manager6/window/DownloadUrlToStorage.js
index 4fe4c669..f1c4392c 100644
--- a/www/manager6/window/DownloadUrlToStorage.js
+++ b/www/manager6/window/DownloadUrlToStorage.js
@@ -165,6 +165,9 @@ Ext.define('PVE.window.DownloadUrlToStorage', {
                     allowBlank: false,
                     fieldLabel: gettext('File name'),
                     emptyText: gettext('Please (re-)query URL to get meta information'),
+                    getSubmitValue: function () {
+                        return this.processRawValue(this.getRawValue())?.trim();
+                    },
                 },
             ],
             column1: [
-- 
2.47.3




                 reply	other threads:[~2026-02-17 12:27 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260217122650.52268-1-l.sichert@proxmox.com \
    --to=l.sichert@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal