public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Filip Schauer <f.schauer@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH manager v2 2/2] ui: lxc/MPEdit: add "keepattrs" flag
Date: Wed, 11 Feb 2026 15:41:10 +0100	[thread overview]
Message-ID: <20260211144111.123837-3-f.schauer@proxmox.com> (raw)
In-Reply-To: <20260211144111.123837-1-f.schauer@proxmox.com>

Expose the "keepattrs" flag for mount points in the UI.

Signed-off-by: Filip Schauer <f.schauer@proxmox.com>
---
This depends on patch 1/2.

Changed since v1:
* Use regular casing for qtip
* Replace "Target Directory" with "mount point directory"
* Replace "Attributes" with "ownership and permissions"

 www/manager6/lxc/MPEdit.js | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/www/manager6/lxc/MPEdit.js b/www/manager6/lxc/MPEdit.js
index f4c45876..4ed2d07b 100644
--- a/www/manager6/lxc/MPEdit.js
+++ b/www/manager6/lxc/MPEdit.js
@@ -47,6 +47,7 @@ Ext.define('PVE.lxc.MountPointInputPanel', {
         setMPOpt('ro', values.ro);
         setMPOpt('acl', values.acl);
         setMPOpt('replicate', values.replicate);
+        setMPOpt('keepattrs', values.keepattrs);
 
         let res = {};
         res[confid] = PVE.Parser.printLxcMountPoint(me.mp);
@@ -338,6 +339,20 @@ Ext.define('PVE.lxc.MountPointInputPanel', {
             name: 'replicate',
             fieldLabel: gettext('Skip replication'),
         },
+        {
+            xtype: 'proxmoxcheckbox',
+            name: 'keepattrs',
+            defaultValue: '0',
+            fieldLabel: gettext('Keep Attributes'),
+            autoEl: {
+                tag: 'div',
+                'data-qtip': gettext('Preserve ownership and permissions of mount point directory'),
+            },
+            bind: {
+                hidden: '{isRoot}',
+                disabled: '{isRoot}',
+            },
+        },
     ],
 });
 
-- 
2.47.3





  parent reply	other threads:[~2026-02-11 14:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-11 14:41 [PATCH container/manager v2 0/2] make mount point attribute preservation configurable Filip Schauer
2026-02-11 14:41 ` [PATCH container v2 1/2] " Filip Schauer
2026-02-11 14:41 ` Filip Schauer [this message]
2026-02-12 14:31 ` applied-series: [PATCH container/manager v2 0/2] " Fabian Grünbichler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260211144111.123837-3-f.schauer@proxmox.com \
    --to=f.schauer@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal