public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Lukas Sichert <l.sichert@proxmox.com>
To: pve-devel@lists.proxmox.com
Cc: Lukas Sichert <l.sichert@proxmox.com>
Subject: [PATCH proxmox-widget-toolkit v2] fix #4911: ui: network edit: allow empty bond-primary
Date: Tue, 10 Feb 2026 11:13:43 +0100	[thread overview]
Message-ID: <20260210101343.20820-1-l.sichert@proxmox.com> (raw)

Currently, when creating an active-backup bond, the bond-primary field
cannot be left blank, even though this value is optional in the backend.
If no value is set in the frontend, it sends the value '' to the
backend.  There, it is interpreted as the name of an interface, which is
incorrect.  This results in the error 'bond-primary: invalid format -
invalid network interface name '' ' being displayed.

The proxmoxtextfield component has a special handling that explicitly
excludes data with value '' from being sent to the backend. Hence, to
fix the bug, switch the bond-primary field from textfield to
proxmoxtextfield.

Additionally, set the deleteEmpty flag, so that devices
deleted in the UI are also deleted in the backend.

Signed-off-by: Lukas Sichert <l.sichert@proxmox.com>
---
 src/node/NetworkEdit.js | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/node/NetworkEdit.js b/src/node/NetworkEdit.js
index 39c7e35..c945139 100644
--- a/src/node/NetworkEdit.js
+++ b/src/node/NetworkEdit.js
@@ -239,10 +239,11 @@ Ext.define('Proxmox.node.NetworkEdit', {
                 disabled: true,
             });
 
-            let primaryfield = Ext.createWidget('textfield', {
+            let primaryfield = Ext.createWidget('proxmoxtextfield', {
                 fieldLabel: 'bond-primary',
                 name: 'bond-primary',
                 value: '',
+                deleteEmpty: !me.isCreate,
                 disabled: true,
             });
 
-- 
2.47.3




             reply	other threads:[~2026-02-10 10:13 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-10 10:13 Lukas Sichert [this message]
2026-02-13 10:35 ` applied: " Dominik Csapak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260210101343.20820-1-l.sichert@proxmox.com \
    --to=l.sichert@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal