[PATCH qemu-server 0/2] config: document default balloon behavior

[PATCH qemu-server 0/2] config: document default balloon behavior

[Maximiliano Sandoval]

Document the behavior and fix a typo.

I discussed this with Fiona off-list, since there are not problems with the
current behavior it is not worth it to turn this into a string property or
special case another value.

Maximiliano Sandoval (2):
  config: fix ballon typo on docstring and comments
  config: document default balloon behavior

 src/PVE/QemuServer.pm | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

-- 
2.47.3

[PATCH qemu-server 1/2] config: fix ballon typo on docstring and comments

[Maximiliano Sandoval]

>From Cambridge Dictionary:
- ballon. noun. a large, round glass, usually used for drinking
brandy.

>From Collins Dictionary:
- ballon. noun. British english. dancing
- ballon. noun. British english. small bale or bundle

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
 src/PVE/QemuServer.pm | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/PVE/QemuServer.pm b/src/PVE/QemuServer.pm
index dae72c40..08cb6b98 100644
--- a/src/PVE/QemuServer.pm
+++ b/src/PVE/QemuServer.pm
@@ -315,7 +315,7 @@ my $confdesc = {
         optional => 1,
         type => 'integer',
         description =>
-            "Amount of target RAM for the VM in MiB. Using zero disables the ballon driver.",
+            "Amount of target RAM for the VM in MiB. Using zero disables the balloon driver.",
         minimum => 0,
     },
     shares => {
@@ -2711,7 +2711,7 @@ sub vmstatus {
         $qmpclient->queue_cmd($qmp_peer, $blockstatscb, 'query-blockstats');
         $qmpclient->queue_cmd($qmp_peer, $machinecb, 'query-machines');
         $qmpclient->queue_cmd($qmp_peer, $versioncb, 'query-version');
-        # this fails if ballon driver is not loaded, so this must be
+        # this fails if balloon driver is not loaded, so this must be
         # the last command (following command are aborted if this fails).
         $qmpclient->queue_cmd($qmp_peer, $ballooncb, 'query-balloon');
 
@@ -4759,7 +4759,7 @@ sub vmconfig_hotplug_pending {
                 die "skip\n" if !$hotplug_features->{cpu};
                 qemu_cpu_hotplug($vmid, $conf, $value);
             } elsif ($opt eq 'balloon') {
-                # enable/disable balloning device is not hotpluggable
+                # enable/disable ballooning device is not hotpluggable
                 my $old_balloon_enabled = !!(!defined($conf->{balloon}) || $conf->{balloon});
                 my $new_balloon_enabled =
                     !!(!defined($conf->{pending}->{balloon}) || $conf->{pending}->{balloon});
-- 
2.47.3

[PATCH qemu-server 2/2] config: document default balloon behavior

[Maximiliano Sandoval]

The behavior for this key is the following:
- balloning=0: Disabled
- Not defined in the config: Enabled
- balloning=N: Enabled, and target memory set to N MiB

Instead of special-casing balloning=1 (or turning it into a property
string) to enable the drive without setting a target memory size, we
simply document the current behavior better.

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
 src/PVE/QemuServer.pm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/PVE/QemuServer.pm b/src/PVE/QemuServer.pm
index 08cb6b98..0395c85b 100644
--- a/src/PVE/QemuServer.pm
+++ b/src/PVE/QemuServer.pm
@@ -315,7 +315,8 @@ my $confdesc = {
         optional => 1,
         type => 'integer',
         description =>
-            "Amount of target RAM for the VM in MiB. Using zero disables the balloon driver.",
+            "Amount of target RAM for the VM in MiB. The balloon driver is enabled by default, "
+            . "unless it is explicitly disabled by setting zero as value.",
         minimum => 0,
     },
     shares => {
-- 
2.47.3

Re: [PATCH qemu-server 2/2] config: document default balloon behavior

[Maximiliano Sandoval]

Maximiliano Sandoval <m.sandoval@proxmox.com> writes:

> The behavior for this key is the following:
> - balloning=0: Disabled
> - Not defined in the config: Enabled
> - balloning=N: Enabled, and target memory set to N MiB

As per the previous commit, there is a typo here. Please let me know if
a v2 is preferable.

> Instead of special-casing balloning=1 (or turning it into a property
> string) to enable the drive without setting a target memory size, we
> simply document the current behavior better.
>
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>

-- 
Maximiliano