public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Arthur Bied-Charreton <a.bied-charreton@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH proxmox-perl-rs 1/1] notify: update bindings with new OAuth2 parameters
Date: Wed,  4 Feb 2026 17:13:45 +0100	[thread overview]
Message-ID: <20260204161354.458814-7-a.bied-charreton@proxmox.com> (raw)
In-Reply-To: <20260204161354.458814-1-a.bied-charreton@proxmox.com>

Update existing bindings for compatibility with the OAuth2-related proxmox-notify
API changes, and add binding for refresh_targets.

Signed-off-by: Arthur Bied-Charreton <a.bied-charreton@proxmox.com>
---
 common/src/bindings/notify.rs | 44 +++++++++++++++++++++++++++++++----
 1 file changed, 40 insertions(+), 4 deletions(-)

diff --git a/common/src/bindings/notify.rs b/common/src/bindings/notify.rs
index 409270a..7d0c54b 100644
--- a/common/src/bindings/notify.rs
+++ b/common/src/bindings/notify.rs
@@ -26,8 +26,8 @@ pub mod proxmox_rs_notify {
         DeleteableSendmailProperty, SendmailConfig, SendmailConfigUpdater,
     };
     use proxmox_notify::endpoints::smtp::{
-        DeleteableSmtpProperty, SmtpConfig, SmtpConfigUpdater, SmtpMode, SmtpPrivateConfig,
-        SmtpPrivateConfigUpdater,
+        DeleteableSmtpProperty, SmtpAuthMethod, SmtpConfig, SmtpConfigUpdater, SmtpMode,
+        SmtpPrivateConfig, SmtpPrivateConfigUpdater,
     };
     use proxmox_notify::endpoints::webhook::{
         DeleteableWebhookProperty, WebhookConfig, WebhookConfigUpdater,
@@ -141,6 +141,17 @@ pub mod proxmox_rs_notify {
         api::common::send(&config, &notification)
     }
 
+    /// Method: Refresh the state for all endpoints.
+    ///
+    /// This iterates through all configured targets, refreshing their state if needed.
+    ///
+    /// See [`api::common::refresh_targets`]
+    #[export(serialize_error)]
+    pub fn refresh_targets(#[try_from_ref] this: &NotificationConfig) -> Result<(), HttpError> {
+        let config = this.config.lock().unwrap();
+        api::common::refresh_targets(&config)
+    }
+
     /// Method: Get a list of all notification targets.
     ///
     /// See [`api::get_targets`].
@@ -396,6 +407,11 @@ pub mod proxmox_rs_notify {
         mode: Option<SmtpMode>,
         username: Option<String>,
         password: Option<String>,
+        auth_method: Option<SmtpAuthMethod>,
+        oauth2_client_id: Option<String>,
+        oauth2_client_secret: Option<String>,
+        oauth2_tenant_id: Option<String>,
+        oauth2_refresh_token: Option<String>,
         mailto: Option<Vec<String>>,
         mailto_user: Option<Vec<String>>,
         from_address: String,
@@ -411,7 +427,10 @@ pub mod proxmox_rs_notify {
                 server,
                 port,
                 mode,
+                auth_method,
                 username,
+                oauth2_client_id,
+                oauth2_tenant_id,
                 mailto: mailto.unwrap_or_default(),
                 mailto_user: mailto_user.unwrap_or_default(),
                 from_address,
@@ -420,7 +439,12 @@ pub mod proxmox_rs_notify {
                 disable,
                 origin: None,
             },
-            SmtpPrivateConfig { name, password },
+            SmtpPrivateConfig {
+                name,
+                password,
+                oauth2_client_secret,
+            },
+            oauth2_refresh_token,
         )
     }
 
@@ -437,6 +461,11 @@ pub mod proxmox_rs_notify {
         mode: Option<SmtpMode>,
         username: Option<String>,
         password: Option<String>,
+        auth_method: Option<SmtpAuthMethod>,
+        oauth2_client_id: Option<String>,
+        oauth2_client_secret: Option<String>,
+        oauth2_tenant_id: Option<String>,
+        oauth2_refresh_token: Option<String>,
         mailto: Option<Vec<String>>,
         mailto_user: Option<Vec<String>>,
         from_address: Option<String>,
@@ -457,6 +486,9 @@ pub mod proxmox_rs_notify {
                 port,
                 mode,
                 username,
+                auth_method,
+                oauth2_client_id,
+                oauth2_tenant_id,
                 mailto,
                 mailto_user,
                 from_address,
@@ -464,7 +496,11 @@ pub mod proxmox_rs_notify {
                 comment,
                 disable,
             },
-            SmtpPrivateConfigUpdater { password },
+            SmtpPrivateConfigUpdater {
+                password,
+                oauth2_client_secret,
+            },
+            oauth2_refresh_token,
             delete.as_deref(),
             digest.as_deref(),
         )
-- 
2.47.3




  parent reply	other threads:[~2026-02-04 16:15 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-04 16:13 [RFC cluster/docs/manager/proxmox{,-perl-rs,-widget-toolkit} 00/15] fix #7238: Add XOAUTH2 authentication support for SMTP notification targets Arthur Bied-Charreton
2026-02-04 16:13 ` [PATCH proxmox 1/5] notify: Introduce xoauth2 module Arthur Bied-Charreton
2026-02-04 16:13 ` [PATCH proxmox 2/5] notify: Add state file handling Arthur Bied-Charreton
2026-02-04 16:13 ` [PATCH proxmox 3/5] notify: Update Endpoint trait and Bus to use State Arthur Bied-Charreton
2026-02-04 16:13 ` [PATCH proxmox 4/5] notify: smtp: add OAuth2/XOAUTH2 authentication support Arthur Bied-Charreton
2026-02-04 16:13 ` [PATCH proxmox 5/5] notify: Add test for State Arthur Bied-Charreton
2026-02-04 16:13 ` Arthur Bied-Charreton [this message]
2026-02-04 16:13 ` [PATCH proxmox-widget-toolkit 1/2] utils: Add OAuth2 flow handlers Arthur Bied-Charreton
2026-02-04 16:13 ` [PATCH proxmox-widget-toolkit 2/2] notifications: Add opt-in OAuth2 support for SMTP targets Arthur Bied-Charreton
2026-02-04 16:13 ` [PATCH pve-manager 1/5] notifications: Add OAuth2 parameters to schema and add/update endpoints Arthur Bied-Charreton
2026-02-04 16:13 ` [PATCH pve-manager 2/5] notifications: Add refresh-targets endpoint Arthur Bied-Charreton
2026-02-04 16:13 ` [PATCH pve-manager 3/5] notifications: Trigger notification target refresh in pveupdate Arthur Bied-Charreton
2026-02-04 16:13 ` [PATCH pve-manager 4/5] notifications: Handle OAuth2 callback in login handler Arthur Bied-Charreton
2026-02-04 16:13 ` [PATCH pve-manager 5/5] notifications: Opt into OAuth2 authentication Arthur Bied-Charreton
2026-02-04 16:13 ` [PATCH pve-cluster 1/1] notifications: Add refresh_targets subroutine to PVE::Notify Arthur Bied-Charreton
2026-02-04 16:13 ` [PATCH pve-docs 1/1] notifications: Add section about OAuth2 to SMTP targets docs Arthur Bied-Charreton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260204161354.458814-7-a.bied-charreton@proxmox.com \
    --to=a.bied-charreton@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal