From: Maximiliano Sandoval <m.sandoval@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH proxmox-i18n v2 3/5] make: remove javascript-format flag from extracted strings
Date: Wed, 4 Feb 2026 14:48:31 +0100 [thread overview]
Message-ID: <20260204134835.422155-4-m.sandoval@proxmox.com> (raw)
In-Reply-To: <20260204134835.422155-1-m.sandoval@proxmox.com>
This provides a hint to gettext that the string uses javascript format
[1], however the format described here does not match how
Ext.String.format operates.
Certain editors, e.g. GTranslator, might refuse to translate a string if
the format on msgstr is broken, hence it is preferable to not have this
flag.
[1] https://www.gnu.org/software/gettext/manual/html_node/javascript_002dformat.html
Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
Makefile | 1 +
1 file changed, 1 insertion(+)
diff --git a/Makefile b/Makefile
index 2e1312ea..31c49432 100644
--- a/Makefile
+++ b/Makefile
@@ -210,6 +210,7 @@ messages.pot: proxmox-widget-toolkit.pot proxmox-mailgateway.pot pve-manager.pot
--msgid-bugs-address="<support@proxmox.com>" \
--copyright-holder="Copyright (C) Proxmox Server Solutions GmbH <support@proxmox.com> & the translation contributors." \
--output $@
+ awk '!/#, javascript-format/' messages.pot > tmpfile && mv tmpfile messages.pot
.PHONY: distclean
distclean: clean
--
2.47.3
next prev parent reply other threads:[~2026-02-04 13:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-04 13:48 [PATCH proxmox-i18n v2 0/5] Fix formats of translated strings Maximiliano Sandoval
2026-02-04 13:48 ` [PATCH proxmox-i18n v2 1/5] ja: remove second plural form Maximiliano Sandoval
2026-02-04 13:48 ` [PATCH proxmox-i18n v2 2/5] fix strings with wrong format Maximiliano Sandoval
2026-02-04 13:48 ` Maximiliano Sandoval [this message]
2026-02-04 13:48 ` [PATCH proxmox-i18n v2 4/5] run make do_update Maximiliano Sandoval
2026-02-04 13:48 ` [PATCH proxmox-i18n v2 5/5] make: add check target Maximiliano Sandoval
2026-02-04 17:37 ` applied: [PATCH proxmox-i18n v2 0/5] Fix formats of translated strings Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260204134835.422155-4-m.sandoval@proxmox.com \
--to=m.sandoval@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox