public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH manager v2 15/17] ui: qemu: make bus selector architecture aware
Date: Tue,  3 Feb 2026 11:00:20 +0100	[thread overview]
Message-ID: <20260203102118.1430545-16-d.csapak@proxmox.com> (raw)
In-Reply-To: <20260203102118.1430545-1-d.csapak@proxmox.com>

by turning it into a FilteredKVComboBox. Filter out 'ide' for aarch64.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 www/manager6/form/BusTypeSelector.js    |  4 +++-
 www/manager6/form/ControllerSelector.js | 17 +++++++++++++++--
 www/manager6/qemu/CDEdit.js             |  4 ++++
 www/manager6/qemu/HDEdit.js             |  3 +++
 www/manager6/qemu/MultiHDEdit.js        |  1 +
 5 files changed, 26 insertions(+), 3 deletions(-)

diff --git a/www/manager6/form/BusTypeSelector.js b/www/manager6/form/BusTypeSelector.js
index 019b2c88..6641ec3a 100644
--- a/www/manager6/form/BusTypeSelector.js
+++ b/www/manager6/form/BusTypeSelector.js
@@ -1,10 +1,12 @@
 Ext.define('PVE.form.BusTypeSelector', {
-    extend: 'Proxmox.form.KVComboBox',
+    extend: 'PVE.form.FilteredKVComboBox',
     alias: 'widget.pveBusSelector',
 
     withVirtIO: true,
     withUnused: false,
 
+    allowedValuesPerCategory: PVE.qemu.Architecture.allowedBusses,
+
     initComponent: function () {
         var me = this;
 
diff --git a/www/manager6/form/ControllerSelector.js b/www/manager6/form/ControllerSelector.js
index fee2b398..365c4970 100644
--- a/www/manager6/form/ControllerSelector.js
+++ b/www/manager6/form/ControllerSelector.js
@@ -24,6 +24,14 @@ Ext.define('PVE.form.ControllerSelector', {
         }
     },
 
+    filterListByArchitecture: function (clist, arch) {
+        let allowedList = PVE.form.BusTypeSelector.prototype.allowedValuesPerCategory[arch];
+        if (!allowedList) {
+            return clist;
+        }
+        return clist.filter((controller) => allowedList.indexOf(controller) !== -1);
+    },
+
     updateVMConfig: function (vmconfig) {
         let me = this;
         me.vmconfig = Ext.apply({}, vmconfig);
@@ -40,10 +48,13 @@ Ext.define('PVE.form.ControllerSelector', {
         let deviceid = me.down('field[name=deviceid]');
 
         let clist;
+        let arch = PVE.qemu.Architecture.getNodeArchitecture(vmconfig.arch, me.nodename);
+        bussel.setCategory(arch);
         if (autoSelect === 'cdrom') {
             if (!Ext.isDefined(me.vmconfig.ide2)) {
-                bussel.setValue('ide');
-                deviceid.setValue(2);
+                let [controller, id] = PVE.qemu.Architecture.defaultCDDrive[arch];
+                bussel.setValue(controller);
+                deviceid.setValue(id);
                 return;
             }
             clist = ['ide', 'scsi', 'sata'];
@@ -52,6 +63,8 @@ Ext.define('PVE.form.ControllerSelector', {
             clist = PVE.Utils.sortByPreviousUsage(me.vmconfig, me.nodename);
         }
 
+        clist = me.filterListByArchitecture(clist, arch);
+
         me.setToFree(clist, bussel, deviceid);
 
         deviceid.validate();
diff --git a/www/manager6/qemu/CDEdit.js b/www/manager6/qemu/CDEdit.js
index 80443b35..c185de53 100644
--- a/www/manager6/qemu/CDEdit.js
+++ b/www/manager6/qemu/CDEdit.js
@@ -55,6 +55,9 @@ Ext.define('PVE.qemu.CDInputPanel', {
         var me = this;
 
         me.isosel.setNodename(nodename);
+        if (me.bussel) {
+            me.bussel.setNodename(nodename);
+        }
     },
 
     initComponent: function () {
@@ -67,6 +70,7 @@ Ext.define('PVE.qemu.CDInputPanel', {
         if (!me.confid) {
             me.bussel = Ext.create('PVE.form.ControllerSelector', {
                 withVirtIO: false,
+                nodename: me.nodename,
             });
             items.push(me.bussel);
         }
diff --git a/www/manager6/qemu/HDEdit.js b/www/manager6/qemu/HDEdit.js
index d5ebfdb9..1bb2bfda 100644
--- a/www/manager6/qemu/HDEdit.js
+++ b/www/manager6/qemu/HDEdit.js
@@ -178,6 +178,7 @@ Ext.define('PVE.qemu.HDInputPanel', {
         me.lookup('import-source')?.setNodename(nodename);
         me.lookup('import-source-file')?.setNodename(nodename);
         me.lookup('import-target')?.setNodename(nodename);
+        me.lookup('controllerSelector')?.setNodename(nodename);
     },
 
     hasAdvanced: true,
@@ -195,7 +196,9 @@ Ext.define('PVE.qemu.HDInputPanel', {
 
         if (!me.confid || me.unused) {
             me.bussel = Ext.create('PVE.form.ControllerSelector', {
+                reference: 'controllerSelector',
                 vmconfig: me.vmconfig,
+                nodename: me.nodename,
                 selectFree: true,
             });
             column1.push(me.bussel);
diff --git a/www/manager6/qemu/MultiHDEdit.js b/www/manager6/qemu/MultiHDEdit.js
index e69f3885..f6b35121 100644
--- a/www/manager6/qemu/MultiHDEdit.js
+++ b/www/manager6/qemu/MultiHDEdit.js
@@ -45,6 +45,7 @@ Ext.define('PVE.qemu.MultiHDPanel', {
             let vm = me.getViewModel();
 
             let res = {
+                arch: vm.get('current.architecture'),
                 scsihw: vm.get('current.scsihw'),
                 ostype: vm.get('current.ostype'),
             };
-- 
2.47.3





  parent reply	other threads:[~2026-02-03 10:21 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-03 10:00 [PATCH manager v2 00/17] enable qemu vm architecture selection Dominik Csapak
2026-02-03 10:00 ` [PATCH manager v2 01/17] api/pvestatd: broadcast and expose non-x86 host architecture Dominik Csapak
2026-02-03 13:56   ` Thomas Lamprecht
2026-02-03 15:07   ` Thomas Lamprecht
2026-02-03 10:00 ` [PATCH manager v2 02/17] ui: qemu: wizard: refactor ostype and cd selector into an OSPanel Dominik Csapak
2026-02-03 10:00 ` [PATCH manager v2 03/17] ui: form: add filtered KVComboBox Dominik Csapak
2026-02-03 10:00 ` [PATCH manager v2 04/17] ui: resource store: add architecture field Dominik Csapak
2026-02-03 10:00 ` [PATCH manager v2 05/17] ui: qemu: add architecture specific defaults and helpers Dominik Csapak
2026-02-03 10:00 ` [PATCH manager v2 06/17] ui: qemu: add architecture field in wizard and hardware view Dominik Csapak
2026-02-03 10:00 ` [PATCH manager v2 07/17] ui: qemu: make scsi hw selector architecture aware Dominik Csapak
2026-02-03 10:00 ` [PATCH manager v2 08/17] ui: qemu: make osdefaults " Dominik Csapak
2026-02-03 10:00 ` [PATCH manager v2 09/17] ui: qemu: make os type selector " Dominik Csapak
2026-02-03 10:00 ` [PATCH manager v2 10/17] ui: qemu: make machine panels/fields " Dominik Csapak
2026-02-03 10:00 ` [PATCH manager v2 11/17] ui: qemu: make bios selector " Dominik Csapak
2026-02-03 10:00 ` [PATCH manager v2 12/17] ui: qemu: make sortByPreviousUsage " Dominik Csapak
2026-02-03 10:00 ` [PATCH manager v2 13/17] ui: qemu: wizard: use defaults to populate machine and bios Dominik Csapak
2026-02-03 10:00 ` [PATCH manager v2 14/17] ui: qemu: wizard: make iso confid architecture specific Dominik Csapak
2026-02-03 10:00 ` Dominik Csapak [this message]
2026-02-03 10:00 ` [PATCH manager v2 16/17] ui: qemu: make processor edit architecture aware Dominik Csapak
2026-02-03 10:00 ` [PATCH manager v2 17/17] ui: qemu: change ui default for cpu model Dominik Csapak
2026-02-03 10:56 ` [PATCH manager v2 00/17] enable qemu vm architecture selection Dominik Csapak
2026-02-03 13:34 ` Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260203102118.1430545-16-d.csapak@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal