From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH manager v2 11/17] ui: qemu: make bios selector architecture aware
Date: Tue, 3 Feb 2026 11:00:16 +0100 [thread overview]
Message-ID: <20260203102118.1430545-12-d.csapak@proxmox.com> (raw)
In-Reply-To: <20260203102118.1430545-1-d.csapak@proxmox.com>
since not all firmware variants are available/supported on every
architecture, limit the selector to variants that make sense (e.g. to
'ovmf' on aarch64).
Same mechanism like the scsi hw selector.
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
www/manager6/form/QemuBiosSelector.js | 18 ++++++++---------
www/manager6/qemu/QemuBiosEdit.js | 29 +++++++++++++++++++++++++--
www/manager6/qemu/SystemEdit.js | 3 +++
3 files changed, 38 insertions(+), 12 deletions(-)
diff --git a/www/manager6/form/QemuBiosSelector.js b/www/manager6/form/QemuBiosSelector.js
index 5fa443f1..40abb589 100644
--- a/www/manager6/form/QemuBiosSelector.js
+++ b/www/manager6/form/QemuBiosSelector.js
@@ -1,16 +1,14 @@
Ext.define('PVE.form.QemuBiosSelector', {
- extend: 'Proxmox.form.KVComboBox',
+ extend: 'PVE.form.FilteredKVComboBox',
alias: ['widget.pveQemuBiosSelector'],
- initComponent: function () {
- var me = this;
+ comboItems: [
+ ['__default__', PVE.Utils.render_qemu_bios('')],
+ ['seabios', PVE.Utils.render_qemu_bios('seabios')],
+ ['ovmf', PVE.Utils.render_qemu_bios('ovmf')],
+ ],
- me.comboItems = [
- ['__default__', PVE.Utils.render_qemu_bios('')],
- ['seabios', PVE.Utils.render_qemu_bios('seabios')],
- ['ovmf', PVE.Utils.render_qemu_bios('ovmf')],
- ];
+ allowedValuesPerCategory: PVE.qemu.Architecture.allowedFirmware,
- me.callParent();
- },
+ setDefaultDisplay: (arch) => PVE.Utils.render_qemu_bios('', arch),
});
diff --git a/www/manager6/qemu/QemuBiosEdit.js b/www/manager6/qemu/QemuBiosEdit.js
index ef8f1844..76e5cfb1 100644
--- a/www/manager6/qemu/QemuBiosEdit.js
+++ b/www/manager6/qemu/QemuBiosEdit.js
@@ -4,7 +4,6 @@ Ext.define('PVE.qemu.BiosEdit', {
onlineHelp: 'qm_bios_and_uefi',
subject: 'BIOS',
- autoLoad: true,
viewModel: {
data: {
@@ -22,7 +21,10 @@ Ext.define('PVE.qemu.BiosEdit', {
onlineHelp: 'qm_bios_and_uefi',
name: 'bios',
value: '__default__',
- bind: '{bios}',
+ bind: {
+ value: '{bios}',
+ category: '{arch}',
+ },
fieldLabel: 'BIOS',
},
{
@@ -42,4 +44,27 @@ Ext.define('PVE.qemu.BiosEdit', {
},
},
],
+
+ initComponent: function () {
+ let me = this;
+
+ me.nodename = me.pveSelNode?.data.node;
+
+ if (!me.nodename) {
+ throw 'no nodename given';
+ }
+
+ me.callParent();
+
+ if (!me.isCreate) {
+ me.load({
+ success: function ({ result }) {
+ let values = result.data;
+ let arch = PVE.qemu.Architecture.getNodeArchitecture(values.arch, me.nodename);
+ me.setValues(values);
+ me.down('pveQemuBiosSelector').setCategory(arch);
+ },
+ });
+ }
+ },
});
diff --git a/www/manager6/qemu/SystemEdit.js b/www/manager6/qemu/SystemEdit.js
index 8bc92bd9..0c1e03ca 100644
--- a/www/manager6/qemu/SystemEdit.js
+++ b/www/manager6/qemu/SystemEdit.js
@@ -102,6 +102,9 @@ Ext.define('PVE.qemu.SystemInputPanel', {
reference: 'bios',
value: '__default__',
fieldLabel: 'BIOS',
+ bind: {
+ category: '{current.architecture}',
+ },
},
{
xtype: 'proxmoxcheckbox',
--
2.47.3
next prev parent reply other threads:[~2026-02-03 10:22 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-03 10:00 [PATCH manager v2 00/17] enable qemu vm architecture selection Dominik Csapak
2026-02-03 10:00 ` [PATCH manager v2 01/17] api/pvestatd: broadcast and expose non-x86 host architecture Dominik Csapak
2026-02-03 13:56 ` Thomas Lamprecht
2026-02-03 15:07 ` Thomas Lamprecht
2026-02-03 10:00 ` [PATCH manager v2 02/17] ui: qemu: wizard: refactor ostype and cd selector into an OSPanel Dominik Csapak
2026-02-03 10:00 ` [PATCH manager v2 03/17] ui: form: add filtered KVComboBox Dominik Csapak
2026-02-03 10:00 ` [PATCH manager v2 04/17] ui: resource store: add architecture field Dominik Csapak
2026-02-03 10:00 ` [PATCH manager v2 05/17] ui: qemu: add architecture specific defaults and helpers Dominik Csapak
2026-02-03 10:00 ` [PATCH manager v2 06/17] ui: qemu: add architecture field in wizard and hardware view Dominik Csapak
2026-02-03 10:00 ` [PATCH manager v2 07/17] ui: qemu: make scsi hw selector architecture aware Dominik Csapak
2026-02-03 10:00 ` [PATCH manager v2 08/17] ui: qemu: make osdefaults " Dominik Csapak
2026-02-03 10:00 ` [PATCH manager v2 09/17] ui: qemu: make os type selector " Dominik Csapak
2026-02-03 10:00 ` [PATCH manager v2 10/17] ui: qemu: make machine panels/fields " Dominik Csapak
2026-02-03 10:00 ` Dominik Csapak [this message]
2026-02-03 10:00 ` [PATCH manager v2 12/17] ui: qemu: make sortByPreviousUsage " Dominik Csapak
2026-02-03 10:00 ` [PATCH manager v2 13/17] ui: qemu: wizard: use defaults to populate machine and bios Dominik Csapak
2026-02-03 10:00 ` [PATCH manager v2 14/17] ui: qemu: wizard: make iso confid architecture specific Dominik Csapak
2026-02-03 10:00 ` [PATCH manager v2 15/17] ui: qemu: make bus selector architecture aware Dominik Csapak
2026-02-03 10:00 ` [PATCH manager v2 16/17] ui: qemu: make processor edit " Dominik Csapak
2026-02-03 10:00 ` [PATCH manager v2 17/17] ui: qemu: change ui default for cpu model Dominik Csapak
2026-02-03 10:56 ` [PATCH manager v2 00/17] enable qemu vm architecture selection Dominik Csapak
2026-02-03 13:34 ` Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260203102118.1430545-12-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox