public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH manager v2 09/17] ui: qemu: make os type selector architecture aware
Date: Tue,  3 Feb 2026 11:00:14 +0100	[thread overview]
Message-ID: <20260203102118.1430545-10-d.csapak@proxmox.com> (raw)
In-Reply-To: <20260203102118.1430545-1-d.csapak@proxmox.com>

A list of valid ostypes for each architecture is defined in PVE.Utils,
and this is used for the os type selector to only show relevant os
types.

Use a setter for 'arch' so we can bind the values again in the wizard,
similar to how the scsi selector is done.

Also update 'me.nodename' in 'setNodename'. This was never necessary
until now, but it is with the 'setArch' logic.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 www/manager6/qemu/OSPanel.js    | 10 ++++++++--
 www/manager6/qemu/OSTypeEdit.js | 26 ++++++++++++++++++++++++++
 www/manager6/qemu/Options.js    |  4 +++-
 3 files changed, 37 insertions(+), 3 deletions(-)

diff --git a/www/manager6/qemu/OSPanel.js b/www/manager6/qemu/OSPanel.js
index dd44c865..136c0316 100644
--- a/www/manager6/qemu/OSPanel.js
+++ b/www/manager6/qemu/OSPanel.js
@@ -36,7 +36,9 @@ Ext.define('PVE.qemu.OSPanel', {
         onOSTypeChange: function (field) {
             var me = this,
                 ostype = field.getValue();
-            var targetValues = PVE.qemu.OSDefaults.getDefaults(ostype);
+
+            let arch = me.getViewModel().get('current.architecture');
+            var targetValues = PVE.qemu.OSDefaults.getDefaults(ostype, arch);
 
             me.setWidget('pveBusSelector', targetValues.busType);
             me.setWidget('pveNetworkCardSelector', targetValues.networkCard);
@@ -77,7 +79,8 @@ Ext.define('PVE.qemu.OSPanel', {
                 updateVMConfig();
                 me.setWidget('pveBusSelector', 'scsi');
                 let ostype = me.getView().down('[name=ostype]').getValue();
-                let targetValues = PVE.qemu.OSDefaults.getDefaults(ostype);
+                let arch = vm.get('current.architecture');
+                let targetValues = PVE.qemu.OSDefaults.getDefaults(ostype, arch);
                 me.setWidget('pveBusSelector', targetValues.busType);
             }
         },
@@ -110,6 +113,9 @@ Ext.define('PVE.qemu.OSPanel', {
                 {
                     xtype: 'pveQemuOSTypePanel',
                     insideWizard: true,
+                    bind: {
+                        arch: '{current.architecture}',
+                    },
                 },
                 {
                     xtype: 'inputpanel',
diff --git a/www/manager6/qemu/OSTypeEdit.js b/www/manager6/qemu/OSTypeEdit.js
index a9508539..dd84d40e 100644
--- a/www/manager6/qemu/OSTypeEdit.js
+++ b/www/manager6/qemu/OSTypeEdit.js
@@ -17,6 +17,25 @@ Ext.define('PVE.qemu.OSTypeInputPanel', {
         },
     },
 
+    setArch: function (arch) {
+        let me = this;
+        me.arch = arch;
+
+        let osbaseStore = me.lookup('osbase').getStore();
+        osbaseStore.clearFilter();
+        let list = PVE.qemu.Architecture.kvmOSTypes[arch]?.bases;
+        if (list) {
+            osbaseStore.addFilter((rec) => list.indexOf(rec.data.field1) !== -1);
+        }
+
+        let ostypeStore = me.lookup('ostype').getStore();
+        ostypeStore.clearFilter();
+        list = PVE.qemu.Architecture.kvmOSTypes[arch]?.ostypes;
+        if (list) {
+            ostypeStore.addFilter((rec) => list.indexOf(rec.data.val) !== -1);
+        }
+    },
+
     onGetValues: function (values) {
         if (values.ide0) {
             let drive = {
@@ -36,6 +55,7 @@ Ext.define('PVE.qemu.OSTypeInputPanel', {
                 xtype: 'combobox',
                 submitValue: false,
                 name: 'osbase',
+                reference: 'osbase',
                 fieldLabel: gettext('Type'),
                 editable: false,
                 queryMode: 'local',
@@ -77,6 +97,7 @@ Ext.define('PVE.qemu.OSTypeInputPanel', {
 
 Ext.define('PVE.qemu.OSTypeEdit', {
     extend: 'Proxmox.window.Edit',
+    alias: 'widget.pveQemuOSTypeEdit',
 
     subject: 'OS Type',
 
@@ -92,6 +113,11 @@ Ext.define('PVE.qemu.OSTypeEdit', {
                 var value = response.result.data.ostype || 'other';
                 var osinfo = PVE.Utils.get_kvm_osinfo(value);
                 me.setValues({ ostype: value, osbase: osinfo.base });
+                let arch = PVE.qemu.Architecture.getNodeArchitecture(
+                    response.result.data.arch,
+                    me.nodename,
+                );
+                me.down('pveQemuOSTypePanel').setArch(arch);
             },
         });
     },
diff --git a/www/manager6/qemu/Options.js b/www/manager6/qemu/Options.js
index 0c0de699..8a4721a0 100644
--- a/www/manager6/qemu/Options.js
+++ b/www/manager6/qemu/Options.js
@@ -86,7 +86,9 @@ Ext.define('PVE.qemu.Options', {
             },
             ostype: {
                 header: gettext('OS Type'),
-                editor: caps.vms['VM.Config.Options'] ? 'PVE.qemu.OSTypeEdit' : undefined,
+                editor: caps.vms['VM.Config.Options']
+                    ? { xtype: 'pveQemuOSTypeEdit', nodename }
+                    : undefined,
                 renderer: PVE.Utils.render_kvm_ostype,
                 defaultValue: 'other',
             },
-- 
2.47.3





  parent reply	other threads:[~2026-02-03 10:22 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-03 10:00 [PATCH manager v2 00/17] enable qemu vm architecture selection Dominik Csapak
2026-02-03 10:00 ` [PATCH manager v2 01/17] api/pvestatd: broadcast and expose non-x86 host architecture Dominik Csapak
2026-02-03 13:56   ` Thomas Lamprecht
2026-02-03 15:07   ` Thomas Lamprecht
2026-02-03 10:00 ` [PATCH manager v2 02/17] ui: qemu: wizard: refactor ostype and cd selector into an OSPanel Dominik Csapak
2026-02-03 10:00 ` [PATCH manager v2 03/17] ui: form: add filtered KVComboBox Dominik Csapak
2026-02-03 10:00 ` [PATCH manager v2 04/17] ui: resource store: add architecture field Dominik Csapak
2026-02-03 10:00 ` [PATCH manager v2 05/17] ui: qemu: add architecture specific defaults and helpers Dominik Csapak
2026-02-03 10:00 ` [PATCH manager v2 06/17] ui: qemu: add architecture field in wizard and hardware view Dominik Csapak
2026-02-03 10:00 ` [PATCH manager v2 07/17] ui: qemu: make scsi hw selector architecture aware Dominik Csapak
2026-02-03 10:00 ` [PATCH manager v2 08/17] ui: qemu: make osdefaults " Dominik Csapak
2026-02-03 10:00 ` Dominik Csapak [this message]
2026-02-03 10:00 ` [PATCH manager v2 10/17] ui: qemu: make machine panels/fields " Dominik Csapak
2026-02-03 10:00 ` [PATCH manager v2 11/17] ui: qemu: make bios selector " Dominik Csapak
2026-02-03 10:00 ` [PATCH manager v2 12/17] ui: qemu: make sortByPreviousUsage " Dominik Csapak
2026-02-03 10:00 ` [PATCH manager v2 13/17] ui: qemu: wizard: use defaults to populate machine and bios Dominik Csapak
2026-02-03 10:00 ` [PATCH manager v2 14/17] ui: qemu: wizard: make iso confid architecture specific Dominik Csapak
2026-02-03 10:00 ` [PATCH manager v2 15/17] ui: qemu: make bus selector architecture aware Dominik Csapak
2026-02-03 10:00 ` [PATCH manager v2 16/17] ui: qemu: make processor edit " Dominik Csapak
2026-02-03 10:00 ` [PATCH manager v2 17/17] ui: qemu: change ui default for cpu model Dominik Csapak
2026-02-03 10:56 ` [PATCH manager v2 00/17] enable qemu vm architecture selection Dominik Csapak
2026-02-03 13:34 ` Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260203102118.1430545-10-d.csapak@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal