From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager v2] ui: pool create: allow selecting parent pool via selector
Date: Fri, 23 Jan 2026 08:42:09 +0100 [thread overview]
Message-ID: <20260123074546.396323-1-d.csapak@proxmox.com> (raw)
instead of having to type out the full path, e.g. 'foo/bar/baz',
show a 'pool selector' to select the parent pool.
Forbid using slashes in the name field so it's not possible to specify
the structure with both the name and parent pool field.
This makes creating nested pools more obvious and easier.
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
changes from v1:
* always delete 'parentPool' from values so we don't accidentally submit it
* only consider parentPool if it's a non-empty string
* add regex to the namefield to disallow slashes
* add emptyText to the poolselector
www/manager6/dc/PoolEdit.js | 52 +++++++++++++++++++++++++++----------
1 file changed, 39 insertions(+), 13 deletions(-)
diff --git a/www/manager6/dc/PoolEdit.js b/www/manager6/dc/PoolEdit.js
index 72a084ac..ee39137a 100644
--- a/www/manager6/dc/PoolEdit.js
+++ b/www/manager6/dc/PoolEdit.js
@@ -17,20 +17,46 @@ Ext.define('PVE.dc.PoolEdit', {
items: [
{
- xtype: 'pmxDisplayEditField',
- fieldLabel: gettext('Name'),
- cbind: {
- editable: '{isCreate}',
- value: '{poolid}',
+ xtype: 'inputpanel',
+ onGetValues: function (values) {
+ if (Ext.isString(values.parentPool) && values.parentPool.length > 0) {
+ values.poolid = values.parentPool + '/' + values.poolid;
+ }
+ delete values.parentPool;
+ return values;
},
- name: 'poolid',
- allowBlank: false,
- },
- {
- xtype: 'textfield',
- fieldLabel: gettext('Comment'),
- name: 'comment',
- allowBlank: true,
+ items: [
+ {
+ xtype: 'pmxDisplayEditField',
+ fieldLabel: gettext('Name'),
+ cbind: {
+ editable: '{isCreate}',
+ value: '{poolid}',
+ },
+ editConfig: {
+ regex: /^[^/]+$/,
+ },
+ name: 'poolid',
+ allowBlank: false,
+ },
+ {
+ xtype: 'pvePoolSelector',
+ name: 'parentPool',
+ fieldLabel: gettext('Parent Pool'),
+ allowBlank: true,
+ emptyText: Proxmox.Utils.NoneText,
+ cbind: {
+ disabled: '{!isCreate}',
+ hidden: '{!isCreate}',
+ },
+ },
+ {
+ xtype: 'textfield',
+ fieldLabel: gettext('Comment'),
+ name: 'comment',
+ allowBlank: true,
+ },
+ ],
},
],
--
2.47.3
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
reply other threads:[~2026-01-23 7:45 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260123074546.396323-1-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox