From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager 2/4] ui: pool create: allow selecting parent pool via selector
Date: Thu, 22 Jan 2026 14:58:32 +0100 [thread overview]
Message-ID: <20260122140143.2256222-3-d.csapak@proxmox.com> (raw)
In-Reply-To: <20260122140143.2256222-1-d.csapak@proxmox.com>
instead of having to type out the full path, e.g. 'foo/bar/baz',
show a 'pool selector' to select the parent pool.
This makes creating nested pools more obvious and easier.
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
www/manager6/dc/PoolEdit.js | 48 +++++++++++++++++++++++++++----------
1 file changed, 35 insertions(+), 13 deletions(-)
diff --git a/www/manager6/dc/PoolEdit.js b/www/manager6/dc/PoolEdit.js
index 72a084ac..325f649b 100644
--- a/www/manager6/dc/PoolEdit.js
+++ b/www/manager6/dc/PoolEdit.js
@@ -17,20 +17,42 @@ Ext.define('PVE.dc.PoolEdit', {
items: [
{
- xtype: 'pmxDisplayEditField',
- fieldLabel: gettext('Name'),
- cbind: {
- editable: '{isCreate}',
- value: '{poolid}',
+ xtype: 'inputpanel',
+ onGetValues: function (values) {
+ if (values.parentPool) {
+ values.poolid = values.parentPool + '/' + values.poolid;
+ delete values.parentPool;
+ }
+ return values;
},
- name: 'poolid',
- allowBlank: false,
- },
- {
- xtype: 'textfield',
- fieldLabel: gettext('Comment'),
- name: 'comment',
- allowBlank: true,
+ items: [
+ {
+ xtype: 'pmxDisplayEditField',
+ fieldLabel: gettext('Name'),
+ cbind: {
+ editable: '{isCreate}',
+ value: '{poolid}',
+ },
+ name: 'poolid',
+ allowBlank: false,
+ },
+ {
+ xtype: 'pvePoolSelector',
+ name: 'parentPool',
+ fieldLabel: gettext('Parent Pool'),
+ allowBlank: true,
+ cbind: {
+ disabled: '{!isCreate}',
+ hidden: '{!isCreate}',
+ },
+ },
+ {
+ xtype: 'textfield',
+ fieldLabel: gettext('Comment'),
+ name: 'comment',
+ allowBlank: true,
+ },
+ ],
},
],
--
2.47.3
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2026-01-22 14:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-22 13:58 [pve-devel] [PATCH manager 0/4] ui: improve ux for nested pools Dominik Csapak
2026-01-22 13:58 ` [pve-devel] [PATCH manager 1/4] ui: tree: don't show empty grouping nodes as expandable Dominik Csapak
2026-01-22 13:58 ` Dominik Csapak [this message]
2026-01-22 15:59 ` [pve-devel] [PATCH manager 2/4] ui: pool create: allow selecting parent pool via selector Thomas Lamprecht
2026-01-23 8:13 ` [pve-devel] superseded: " Dominik Csapak
2026-01-22 13:58 ` [pve-devel] [PATCH manager 3/4] ui: tree: show nested pools in a nested way Dominik Csapak
2026-01-22 13:58 ` [pve-devel] [PATCH manager 4/4] ui: tree: render nested pool names without parent pools Dominik Csapak
2026-01-22 19:59 ` [pve-devel] partially-applied: [PATCH manager 0/4] ui: improve ux for nested pools Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260122140143.2256222-3-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox