From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager 1/4] ui: tree: don't show empty grouping nodes as expandable
Date: Thu, 22 Jan 2026 14:58:31 +0100 [thread overview]
Message-ID: <20260122140143.2256222-2-d.csapak@proxmox.com> (raw)
In-Reply-To: <20260122140143.2256222-1-d.csapak@proxmox.com>
Non empty nodes in the tree automatically will show an arrow to expand
them. When grouping, this is currently forced by setting 'leaf' to
false, so they always show an 'expanding arrow', which vanishes when
trying to expand such an item.
Instead, simply let the tree add that automatically when a node has
children. This makes it instantly visible which nodes have children an
which do not.
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
www/manager6/tree/ResourceTree.js | 1 -
1 file changed, 1 deletion(-)
diff --git a/www/manager6/tree/ResourceTree.js b/www/manager6/tree/ResourceTree.js
index bb016f8c..76d58e2f 100644
--- a/www/manager6/tree/ResourceTree.js
+++ b/www/manager6/tree/ResourceTree.js
@@ -253,7 +253,6 @@ Ext.define('PVE.tree.ResourceTree', {
groupinfo[groupBy] = v;
}
}
- groupinfo.leaf = false;
groupinfo.groupbyid = v;
group = me.addChildSorted(node, groupinfo);
}
--
2.47.3
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2026-01-22 14:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-22 13:58 [pve-devel] [PATCH manager 0/4] ui: improve ux for nested pools Dominik Csapak
2026-01-22 13:58 ` Dominik Csapak [this message]
2026-01-22 13:58 ` [pve-devel] [PATCH manager 2/4] ui: pool create: allow selecting parent pool via selector Dominik Csapak
2026-01-22 15:59 ` Thomas Lamprecht
2026-01-23 8:13 ` [pve-devel] superseded: " Dominik Csapak
2026-01-22 13:58 ` [pve-devel] [PATCH manager 3/4] ui: tree: show nested pools in a nested way Dominik Csapak
2026-01-22 13:58 ` [pve-devel] [PATCH manager 4/4] ui: tree: render nested pool names without parent pools Dominik Csapak
2026-01-22 19:59 ` [pve-devel] partially-applied: [PATCH manager 0/4] ui: improve ux for nested pools Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260122140143.2256222-2-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox