[pve-devel] [PATCH ha-manager 0/1] prevent adding possibly non-existent nodes

[pve-devel] [PATCH ha-manager 0/1] prevent adding possibly non-existent nodes

[Daniel Kral]

A small patch that removes the possibility to add possibly non-existent
nodes through get_node_state(...), node_is_online(...),
node_is_operational(...) and node_is_offline_delayed(...), which makes
the output of list_nodes() incorrect.

Most call sites will output an "node is not online" error to the
relevant log, but there is no output to the user, which is a possible
improvement for another patch series.


Daniel Kral (1):
  nodestate: do not write unknown node status in get_node_state

 src/PVE/HA/NodeStatus.pm | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

-- 
2.47.3



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH ha-manager 1/1] nodestate: do not write unknown node status in get_node_state

[Daniel Kral]

PVE::HA::NodeStatus->get_node_state($node) and its proxies are accessed
by many call sites with untrusted input data, e.g., migrate/relocate crm
commands, node maintenance commands, etc.

For example, if node 'node19' does not exist, and a user issues the
migrate command, 'node19' will be written to the node state and will
stay there until it is removed as a gone node (after ~60 min):

    $ ha-manager migrate vm:100 node19
    $ ha-manager status
    unable to read file '/etc/pve/nodes/node19/lrm_status'
    quorum OK
    [...]
    lrm node19 (unable to read lrm status)
    [...]

As the transition between unknown/gone and other node states are already
handled by PVE::HA::NodeStatus->update(...), remove this side effect
from get_node_state(...).

Signed-off-by: Daniel Kral <d.kral@proxmox.com>
---
 src/PVE/HA/NodeStatus.pm | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/src/PVE/HA/NodeStatus.pm b/src/PVE/HA/NodeStatus.pm
index e5dddf3b..381be7d0 100644
--- a/src/PVE/HA/NodeStatus.pm
+++ b/src/PVE/HA/NodeStatus.pm
@@ -33,10 +33,7 @@ my $valid_node_states = {
 sub get_node_state {
     my ($self, $node) = @_;
 
-    $self->{status}->{$node} = 'unknown'
-        if !$self->{status}->{$node};
-
-    return $self->{status}->{$node};
+    return $self->{status}->{$node} // 'unknown';
 }
 
 sub node_is_operational {
-- 
2.47.3



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH ha-manager 0/1] prevent adding possibly non-existent nodes

[Fiona Ebner]

On Thu, 22 Jan 2026 10:19:34 +0100, Daniel Kral wrote:
> A small patch that removes the possibility to add possibly non-existent
> nodes through get_node_state(...), node_is_online(...),
> node_is_operational(...) and node_is_offline_delayed(...), which makes
> the output of list_nodes() incorrect.
> 
> Most call sites will output an "node is not online" error to the
> relevant log, but there is no output to the user, which is a possible
> improvement for another patch series.
> 
> [...]

Applied, thanks!

[1/1] nodestate: do not write unknown node status in get_node_state
      commit: 08c7f0b5863063bf2ee6cab154651be77a2c5aa7


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel