[pve-devel] [PATCH-SERIES ha-manager v2 0/4] fix #7133 and improve HA group migration

[Daniel Kral <d.kral@proxmox.com>]

Changes from v1 to v2 (Thanks @Fiona!):
    - pull $delete parameter into $changes hash in
      update_{service,resources}_config
    - sort the HA resources' sids when iterating over the $changes hash

Tested the changes for v2 again with:
    - creating a groups.cfg and checking whether the groups have been
      correctly migrated,
    - changing a HA resource to stopped state changes the config too, &
    - changing a HA resource's config through the API reflects the
      changes in the resources.cfg.


This small patch series improves the HA groups to rules migration for HA
setups with a lot of HA resources:

- Patch 1 reduces the amount of unnecessary updates and is enough for
  fixing #7133,
- Patch 2 removes redundant failback flag writes to reduce the resource
  config file size, and patch, and
- Patch 3-4 make the resource config in a single write instead of
  individual writes.

Tested this for a PVE 8.4 to PVE 9.1 3-node cluster upgrade.

Daniel Kral (4):
  fix #7133: manager: group migration: skip update for resources without
    group
  manager: group migration: write only non-default failback values
  config, env: allow bulk updates with update_service_config
  manager: group migration: bulk update changes to resource config

 src/PVE/API2/HA/Resources.pm |  8 ++++-
 src/PVE/HA/Config.pm         | 57 +++++++++++++++++++++---------------
 src/PVE/HA/Env.pm            |  4 +--
 src/PVE/HA/Env/PVE2.pm       |  4 +--
 src/PVE/HA/Manager.pm        | 15 ++++++++--
 src/PVE/HA/Sim/Env.pm        |  4 +--
 src/PVE/HA/Sim/Hardware.pm   | 19 +++++++++---
 7 files changed, 74 insertions(+), 37 deletions(-)

-- 
2.47.3



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel