public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Maximiliano Sandoval <m.sandoval@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH qemu-server v4 5/8] port users of guest-fsfreeze-thaw users to helper
Date: Fri,  2 Jan 2026 15:35:40 +0100	[thread overview]
Message-ID: <20260102143544.354066-6-m.sandoval@proxmox.com> (raw)
In-Reply-To: <20260102143544.354066-1-m.sandoval@proxmox.com>

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
 src/PVE/QemuConfig.pm          | 2 +-
 src/PVE/QemuServer/BlockJob.pm | 2 +-
 src/PVE/VZDump/QemuServer.pm   | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/PVE/QemuConfig.pm b/src/PVE/QemuConfig.pm
index 803e4da4..bd67be1a 100644
--- a/src/PVE/QemuConfig.pm
+++ b/src/PVE/QemuConfig.pm
@@ -310,7 +310,7 @@ sub __snapshot_freeze {
     my ($class, $vmid, $unfreeze) = @_;
 
     if ($unfreeze) {
-        eval { mon_cmd($vmid, "guest-fsfreeze-thaw"); };
+        eval { PVE::QemuServer::Agent::guest_fsthaw($vmid); };
         warn "guest-fsfreeze-thaw problems - $@" if $@;
     } else {
         eval { PVE::QemuServer::Agent::guest_fsfreeze($vmid); };
diff --git a/src/PVE/QemuServer/BlockJob.pm b/src/PVE/QemuServer/BlockJob.pm
index c89994db..b25dcf9a 100644
--- a/src/PVE/QemuServer/BlockJob.pm
+++ b/src/PVE/QemuServer/BlockJob.pm
@@ -178,7 +178,7 @@ sub qemu_drive_mirror_monitor {
 
                     if ($agent_running) {
                         print "unfreeze filesystem\n";
-                        eval { mon_cmd($vmid, "guest-fsfreeze-thaw"); };
+                        eval { PVE::QemuServer::Agent::guest_fsthaw($vmid); };
                         warn $@ if $@;
                     } else {
                         print "resume vm\n";
diff --git a/src/PVE/VZDump/QemuServer.pm b/src/PVE/VZDump/QemuServer.pm
index af684a1d..58c86547 100644
--- a/src/PVE/VZDump/QemuServer.pm
+++ b/src/PVE/VZDump/QemuServer.pm
@@ -1124,7 +1124,7 @@ sub qga_fs_thaw {
     my ($self, $vmid) = @_;
 
     $self->loginfo("issuing guest-agent 'fs-thaw' command");
-    eval { mon_cmd($vmid, "guest-fsfreeze-thaw") };
+    eval { PVE::QemuServer::Agent::guest_fsthaw($vmid); };
     $self->logerr($@) if $@;
 }
 
-- 
2.47.3



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


  parent reply	other threads:[~2026-01-02 14:35 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-02 14:35 [pve-devel] [PATCH guest-common/qemu-server v4 0/9] fix #1964: add setting to always disable freezing a guest's fs Maximiliano Sandoval
2026-01-02 14:35 ` [pve-devel] [PATCH qemu-server v4 1/8] add a guest-fsfreeze qga setting Maximiliano Sandoval
2026-01-02 14:35 ` [pve-devel] [PATCH qemu-server v4 2/8] api: clone_vm: follow guest-fsfreeze setting Maximiliano Sandoval
2026-01-02 14:35 ` [pve-devel] [PATCH qemu-server v4 3/8] fix #1964: follow guest-fsfreeze setting on check freeze needed Maximiliano Sandoval
2026-01-02 14:35 ` [pve-devel] [PATCH qemu-server v4 4/8] agent: add a guest_fsthaw helper Maximiliano Sandoval
2026-01-02 14:35 ` Maximiliano Sandoval [this message]
2026-01-02 14:35 ` [pve-devel] [PATCH qemu-server v4 6/8] block job: log when a fsfreeze could not happen Maximiliano Sandoval
2026-01-02 14:35 ` [pve-devel] [PATCH qemu-server v4 7/8] block job: mirror: reword fsfreeze log entry Maximiliano Sandoval
2026-01-02 14:35 ` [pve-devel] [PATCH qemu-server v4 8/8] deprecate freeze-fs-on-backup qga setting Maximiliano Sandoval
2026-01-02 14:35 ` [pve-devel] [PATCH guest-common v4 1/1] abstract config: print when {, un}freezing a fs Maximiliano Sandoval
2026-01-02 15:27 ` [pve-devel] [PATCH guest-common/qemu-server v4 0/9] fix #1964: add setting to always disable freezing a guest's fs Maximiliano Sandoval
2026-01-02 15:36   ` Fiona Ebner
2026-01-05 12:55 ` [pve-devel] superseded: " Maximiliano Sandoval

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260102143544.354066-6-m.sandoval@proxmox.com \
    --to=m.sandoval@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal