[pve-devel] [PATCH proxmox-widget-toolkit] fix #7087: ui: enable direct task log download

[pve-devel] [PATCH proxmox-widget-toolkit] fix #7087: ui: enable direct task log download

[Dominik Rusovac]

The web ui of both, PVE and PBS, now includes a "Download" button
allowing for a task log to be downloaded directly without opening the
task viewer pop-up.

The enhancement originally related to PBS only, however this change
applies to PVE too and it seems more convenient to have it for both.

Signed-off-by: Dominik Rusovac <d.rusovac@proxmox.com>
---

Notes:
    If desired, I could take on the implementation of download buttons for PDM.

 src/node/Tasks.js | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/src/node/Tasks.js b/src/node/Tasks.js
index 661329a..002d909 100644
--- a/src/node/Tasks.js
+++ b/src/node/Tasks.js
@@ -35,6 +35,21 @@ Ext.define('Proxmox.node.Tasks', {
             }).show();
         },
 
+        downloadTaskLog: function () {
+            let me = this;
+            let selection = me.getView().getSelection();
+            if (selection.length < 1) {
+                return;
+            }
+
+            let rec = selection[0];
+            let task = Proxmox.Utils.parse_task_upid(rec.data.upid);
+
+            Proxmox.Utils.downloadAsFile(
+                `/api2/json/nodes/${task.node}/tasks/${encodeURIComponent(rec.data.upid)}/log?download=1`,
+            );
+        },
+
         updateLayout: function (store, records, success, operation) {
             let me = this;
             let view = me.getView().getView(); // the table view, not the whole grid
@@ -236,6 +251,13 @@ Ext.define('Proxmox.node.Tasks', {
                     disabled: true,
                     handler: 'showTaskLog',
                 },
+                {
+                    xtype: 'proxmoxButton',
+                    text: gettext('Download'),
+                    iconCls: 'fa fa-download',
+                    disabled: true,
+                    handler: 'downloadTaskLog',
+                },
                 {
                     xtype: 'button',
                     text: gettext('Reload'),
-- 
2.47.3



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel