public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Rusovac <d.rusovac@proxmox.com>
To: pve-devel@lists.proxmox.com
Cc: Dominik Rusovac <d.rusovac@proxmox.com>
Subject: [pve-devel] [PATCH proxmox-widget-toolkit] fix #7087: ui: enable direct task log download
Date: Fri, 19 Dec 2025 15:46:35 +0100	[thread overview]
Message-ID: <20251219144635.168818-1-d.rusovac@proxmox.com> (raw)

The web ui of both, PVE and PBS, now includes a "Download" button
allowing for a task log to be downloaded directly without opening the
task viewer pop-up.

The enhancement originally related to PBS only, however this change
applies to PVE too and it seems more convenient to have it for both.

Signed-off-by: Dominik Rusovac <d.rusovac@proxmox.com>
---

Notes:
    If desired, I could take on the implementation of download buttons for PDM.

 src/node/Tasks.js | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/src/node/Tasks.js b/src/node/Tasks.js
index 661329a..002d909 100644
--- a/src/node/Tasks.js
+++ b/src/node/Tasks.js
@@ -35,6 +35,21 @@ Ext.define('Proxmox.node.Tasks', {
             }).show();
         },
 
+        downloadTaskLog: function () {
+            let me = this;
+            let selection = me.getView().getSelection();
+            if (selection.length < 1) {
+                return;
+            }
+
+            let rec = selection[0];
+            let task = Proxmox.Utils.parse_task_upid(rec.data.upid);
+
+            Proxmox.Utils.downloadAsFile(
+                `/api2/json/nodes/${task.node}/tasks/${encodeURIComponent(rec.data.upid)}/log?download=1`,
+            );
+        },
+
         updateLayout: function (store, records, success, operation) {
             let me = this;
             let view = me.getView().getView(); // the table view, not the whole grid
@@ -236,6 +251,13 @@ Ext.define('Proxmox.node.Tasks', {
                     disabled: true,
                     handler: 'showTaskLog',
                 },
+                {
+                    xtype: 'proxmoxButton',
+                    text: gettext('Download'),
+                    iconCls: 'fa fa-download',
+                    disabled: true,
+                    handler: 'downloadTaskLog',
+                },
                 {
                     xtype: 'button',
                     text: gettext('Reload'),
-- 
2.47.3



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


                 reply	other threads:[~2025-12-19 14:46 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251219144635.168818-1-d.rusovac@proxmox.com \
    --to=d.rusovac@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal