[pve-devel] [PATCH qemu-server/pve-{manager, storage} 0/3] fix OVMF typos

[pve-devel] [PATCH qemu-server/pve-{manager, storage} 0/3] fix OVMF typos

[Christoph Heiss]

Essentially `s/OMVF/OVMF/g` (its "Open Virtual Machine Firmware").
Grepped through ~all PVE repositories, so hopefully found all instances
of this typo.

Diffstat
========

qemu-server:

Christoph Heiss (1):
  config: fix OVMF typo in error message

 src/PVE/QemuConfig.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

pve-manager:

Christoph Heiss (1):
  ui: utils: fix OVMF typo in error message translation

 www/manager6/Utils.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

pve-storage:

Christoph Heiss (1):
  plugin: fix OVMF typo in subroutine documentation

 src/PVE/Storage/Plugin.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.51.2



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH qemu-server 1/3] config: fix OVMF typo in error message

[Christoph Heiss]

Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
---
As we translate that string in the UI (see also next patch), this can
lead to this error being untranslated in the UI in certain package
version combinations (i.e. newer qemu-server, older pve-manager). 

Not sure if we consider something like that breaking though, at has
least no functional impact per se.

 src/PVE/QemuConfig.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/PVE/QemuConfig.pm b/src/PVE/QemuConfig.pm
index ad6ce6b0..844ed69a 100644
--- a/src/PVE/QemuConfig.pm
+++ b/src/PVE/QemuConfig.pm
@@ -194,7 +194,7 @@ sub get_backup_volumes {
 
         if ($key =~ m/^efidisk/ && (!defined($conf->{bios}) || $conf->{bios} ne 'ovmf')) {
             $included = 0;
-            $reason = "efidisk but no OMVF BIOS";
+            $reason = "efidisk but no OVMF BIOS";
         }
 
         push @$return_volumes,
-- 
2.51.2



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH manager 2/3] ui: utils: fix OVMF typo in error message translation

[Christoph Heiss]

Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
---
 www/manager6/Utils.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js
index 0e0751e76..2992f6553 100644
--- a/www/manager6/Utils.js
+++ b/www/manager6/Utils.js
@@ -402,7 +402,7 @@ Ext.define('PVE.Utils', {
             enabled: gettext('Enabled'),
             disabled: gettext('Disabled'),
             'not a volume': gettext('Not a volume'),
-            'efidisk but no OMVF BIOS': gettext('EFI Disk without OMVF BIOS'),
+            'efidisk but no OVMF BIOS': gettext('EFI Disk without OVMF BIOS'),
         },
 
         renderNotFound: (what) => Ext.String.format(gettext('No {0} found'), what),
-- 
2.51.2



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH storage 3/3] plugin: fix OVMF typo in subroutine documentation

[Christoph Heiss]

Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
---
While not user-visible, found it while grepping through everything, so
fix it up too while at it.

 src/PVE/Storage/Plugin.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/PVE/Storage/Plugin.pm b/src/PVE/Storage/Plugin.pm
index 6f2e434..6f3d691 100644
--- a/src/PVE/Storage/Plugin.pm
+++ b/src/PVE/Storage/Plugin.pm
@@ -2420,7 +2420,7 @@ the future.
 =over
 
 =item C<< $options->{hints}->{'efi-disk'} >>: (optional) If set, the volume will be used as the EFI
-disk of a VM, containing its OMVF variables.
+disk of a VM, containing its OVMF variables.
 
 =back
 
-- 
2.51.2



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel