public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH-SERIES storage/qemu-server 00/11] fix #7094: external snapshot delete: ensure commit target is large enough
Date: Tue, 16 Dec 2025 14:02:11 +0100	[thread overview]
Message-ID: <20251216130230.104772-1-f.ebner@proxmox.com> (raw)

For LVM storages using 'snapshot-as-volume-chain', it's necessary to
ensure that the size for the LV of the target snapshot volume is large
enough before doing a commit operation. This affects both the offline
and the online case, which have different code paths.

To make this possible via the storage (plugin) API, the
volume_resize() method gains a new 'snapname' parameter and the
'virtual-size' of each snapshot is returned in the result of
volume_snapshot_info().

The series also adds documentation for volume_resize() and
volume_snapshot_info(), the latter of which is a bit hairy, since it
was previously only used for ZFS replication and then re-used for
snapshot-as-volume-chain which returns quite different information.
It's not too bad though.

Lastly, there's some cleanups for the volume_snapshot_info() method.


Storage plugin API age and version are bumped in the series.
Dependency bump from qemu-server to libpve-storage-perl needed!


storage:

Fiona Ebner (10):
  plugin: document volume_snapshot_info() method
  plugin: volume snapshot info: also return virtual size
  plugin: document volume_resize() method
  plugin/storage: volume resize: add snapname parameter
  lvm plugin: snapshot delete: clarify comment about using commit
  bump API age and version
  partially fix #7094: lvm: snapshot delete: ensure commit target is
    large enough
  plugin: volume snapshot info: don't set 'order' for internal snapshots
  plugin: volume snapshot info: correctly return internal snapshot
    information
  plugin: volume snapshot info: do not set 'ext' property

 ApiChangeLog                         |  20 ++++++
 src/PVE/Storage.pm                   |   8 +--
 src/PVE/Storage/BTRFSPlugin.pm       |   3 +-
 src/PVE/Storage/ESXiPlugin.pm        |   2 +-
 src/PVE/Storage/ISCSIDirectPlugin.pm |   2 +-
 src/PVE/Storage/ISCSIPlugin.pm       |   2 +-
 src/PVE/Storage/LVMPlugin.pm         |  21 ++++--
 src/PVE/Storage/LvmThinPlugin.pm     |   8 ++-
 src/PVE/Storage/PBSPlugin.pm         |   2 +-
 src/PVE/Storage/Plugin.pm            | 103 +++++++++++++++++++++------
 src/PVE/Storage/RBDPlugin.pm         |   4 +-
 src/PVE/Storage/ZFSPlugin.pm         |   5 +-
 src/PVE/Storage/ZFSPoolPlugin.pm     |   4 +-
 13 files changed, 145 insertions(+), 39 deletions(-)


qemu-server:

Fiona Ebner (1):
  partially fix #7094: external snapshot delete: ensure commit target is
    large enough

 src/PVE/QemuServer.pm | 9 +++++++++
 1 file changed, 9 insertions(+)


Summary over all repositories:
  14 files changed, 154 insertions(+), 39 deletions(-)

-- 
Generated by git-murpp 0.5.0


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


             reply	other threads:[~2025-12-16 13:01 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-16 13:02 Fiona Ebner [this message]
2025-12-16 13:02 ` [pve-devel] [PATCH storage 01/11] plugin: document volume_snapshot_info() method Fiona Ebner
2025-12-16 13:02 ` [pve-devel] [PATCH storage 02/11] plugin: volume snapshot info: also return virtual size Fiona Ebner
2025-12-16 13:02 ` [pve-devel] [PATCH storage 03/11] plugin: document volume_resize() method Fiona Ebner
2025-12-16 13:02 ` [pve-devel] [PATCH storage 04/11] plugin/storage: volume resize: add snapname parameter Fiona Ebner
2025-12-16 13:02 ` [pve-devel] [PATCH storage 05/11] lvm plugin: snapshot delete: clarify comment about using commit Fiona Ebner
2025-12-16 13:02 ` [pve-devel] [PATCH storage 06/11] bump API age and version Fiona Ebner
2025-12-16 13:02 ` [pve-devel] [PATCH storage 07/11] partially fix #7094: lvm: snapshot delete: ensure commit target is large enough Fiona Ebner
2025-12-16 13:02 ` [pve-devel] [PATCH storage 08/11] plugin: volume snapshot info: don't set 'order' for internal snapshots Fiona Ebner
2025-12-16 13:02 ` [pve-devel] [PATCH storage 09/11] plugin: volume snapshot info: correctly return internal snapshot information Fiona Ebner
2025-12-16 13:02 ` [pve-devel] [PATCH storage 10/11] plugin: volume snapshot info: do not set 'ext' property Fiona Ebner
2025-12-16 13:02 ` [pve-devel] [PATCH qemu-server 11/11] partially fix #7094: external snapshot delete: ensure commit target is large enough Fiona Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251216130230.104772-1-f.ebner@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal