[pve-devel] [PATCH widget-toolkit] RRDTypeSelector: fix extjs debug mode

[pve-devel] [PATCH widget-toolkit] RRDTypeSelector: fix extjs debug mode

[Dominik Csapak]

For some reason, using a space separated list of classes in `itemCls`
breaks the extjs debug mode. This is seemingly allowed everywhere else,
so to fix it, simply apply the classes directly to the children
with 'default'.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 src/form/RRDTypeSelector.js | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/form/RRDTypeSelector.js b/src/form/RRDTypeSelector.js
index bbb5d86..51ae23a 100644
--- a/src/form/RRDTypeSelector.js
+++ b/src/form/RRDTypeSelector.js
@@ -75,7 +75,9 @@ Ext.define('Proxmox.form.RRDTypeSelector', {
             xtype: 'segmentedbutton',
             allowMultiple: false,
             allowToggle: true,
-            itemCls: 'x-btn-default-toolbar-small proxmox-inline-button',
+            defautl: {
+                cls: 'x-btn-default-toolbar-small proxmox-inline-button',
+            },
             items: [
                 {
                     text: gettext('Maximum'),
-- 
2.47.3



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH widget-toolkit] RRDTypeSelector: fix extjs debug mode

[Max R. Carrara]

On Fri Dec 5, 2025 at 3:34 PM CET, Dominik Csapak wrote:
> For some reason, using a space separated list of classes in `itemCls`
> breaks the extjs debug mode. This is seemingly allowed everywhere else,
> so to fix it, simply apply the classes directly to the children
> with 'default'.
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
>  src/form/RRDTypeSelector.js | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/src/form/RRDTypeSelector.js b/src/form/RRDTypeSelector.js
> index bbb5d86..51ae23a 100644
> --- a/src/form/RRDTypeSelector.js
> +++ b/src/form/RRDTypeSelector.js
> @@ -75,7 +75,9 @@ Ext.define('Proxmox.form.RRDTypeSelector', {
>              xtype: 'segmentedbutton',
>              allowMultiple: false,
>              allowToggle: true,
> -            itemCls: 'x-btn-default-toolbar-small proxmox-inline-button',
> +            defautl: {

s/defautl/default ;)

Thanks for identifying and fixing this so quickly!

> +                cls: 'x-btn-default-toolbar-small proxmox-inline-button',
> +            },
>              items: [
>                  {
>                      text: gettext('Maximum'),



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH widget-toolkit] RRDTypeSelector: fix extjs debug mode

[Thomas Lamprecht]

Am 05.12.25 um 15:34 schrieb Dominik Csapak:
> For some reason, using a space separated list of classes in `itemCls`
> breaks the extjs debug mode. This is seemingly allowed everywhere else,
> so to fix it, simply apply the classes directly to the children
> with 'default'.

This is what I mentioned off-list a two weeks or so ago, I lost track off
it so thx for checking again.

> 
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
>  src/form/RRDTypeSelector.js | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/src/form/RRDTypeSelector.js b/src/form/RRDTypeSelector.js
> index bbb5d86..51ae23a 100644
> --- a/src/form/RRDTypeSelector.js
> +++ b/src/form/RRDTypeSelector.js
> @@ -75,7 +75,9 @@ Ext.define('Proxmox.form.RRDTypeSelector', {
>              xtype: 'segmentedbutton',
>              allowMultiple: false,
>              allowToggle: true,
> -            itemCls: 'x-btn-default-toolbar-small proxmox-inline-button',
> +            defautl: {
> +                cls: 'x-btn-default-toolbar-small proxmox-inline-button',
> +            },

using an array makes it work too here:

itemCls: ['x-btn-default-toolbar-small', 'proxmox-inline-button'],

But your variant is probably the slightly nicer one I think.

>              items: [
>                  {
>                      text: gettext('Maximum'),



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH widget-toolkit] RRDTypeSelector: fix extjs debug mode

[Thomas Lamprecht]

On Fri, 05 Dec 2025 15:34:45 +0100, Dominik Csapak wrote:
> For some reason, using a space separated list of classes in `itemCls`
> breaks the extjs debug mode. This is seemingly allowed everywhere else,
> so to fix it, simply apply the classes directly to the children
> with 'default'.
> 
> 

Applied, thanks!

[1/1] RRDTypeSelector: fix extjs debug mode
      commit: 54a2e4173c47e7891af9cbbbdbf4f976a924fc7c


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel