From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH qemu-server] qmp client: bump timeout for synchronous blockdev snapshot commands to 1 hour
Date: Fri, 28 Nov 2025 15:56:11 +0100 [thread overview]
Message-ID: <20251128145622.163185-1-f.ebner@proxmox.com> (raw)
It's a commonly reported issue, most recently again in the enterprise
support, that taking or removing snapshots of large qcow2 files on
file-based network storages runs into a timeout. If the timeout is
hit, that just means additional manual steps to clean up afterwards
for users. The synchronous QMP command will still be blocking the main
thread of the QEMU instance until it has run to completion. Therefore,
a longer timeout does not really hurt here, while reducing the number
of times the aforementioned cleanup is necessary.
In the long term, using snapshot-as-volume-chain should be a good
alternative for such cases, once it's deemed production-ready.
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
src/PVE/QMPClient.pm | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/src/PVE/QMPClient.pm b/src/PVE/QMPClient.pm
index e4f7a515..c3ed0e32 100644
--- a/src/PVE/QMPClient.pm
+++ b/src/PVE/QMPClient.pm
@@ -132,8 +132,6 @@ sub cmd {
$cmd->{execute} eq 'backup-cancel'
|| $cmd->{execute} eq 'blockdev-del'
|| $cmd->{execute} eq 'blockdev-mirror'
- || $cmd->{execute} eq 'blockdev-snapshot-delete-internal-sync'
- || $cmd->{execute} eq 'blockdev-snapshot-internal-sync'
|| $cmd->{execute} eq 'block-job-cancel'
|| $cmd->{execute} eq 'block-job-complete'
|| $cmd->{execute} eq 'drive-mirror'
@@ -146,6 +144,11 @@ sub cmd {
|| $cmd->{execute} eq 'savevm-start'
) {
$timeout = 10 * 60; # 10 mins
+ } elsif (
+ $cmd->{execute} eq 'blockdev-snapshot-delete-internal-sync'
+ || $cmd->{execute} eq 'blockdev-snapshot-internal-sync'
+ ) {
+ $timeout = 60 * 60; # 1 hour
} else {
# NOTE: if you came here as user and want to change this, try using IO-Threads first
# which move out quite some processing of the main thread, leaving more time for QMP
--
2.47.3
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next reply other threads:[~2025-11-28 14:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-28 14:56 Fiona Ebner [this message]
2025-11-28 17:06 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251128145622.163185-1-f.ebner@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox