From: Stoiko Ivanov <s.ivanov@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH installer 0/2] nic pinning: require first character to be lower-case
Date: Tue, 18 Nov 2025 16:15:25 +0100 [thread overview]
Message-ID: <20251118151532.592423-1-s.ivanov@proxmox.com> (raw)
The regex for validating NICs in pve-common starts with /^[a-z].../
getting 'name must start with a letter' to a pinned nic-name of 'ABC' is
confusing. Additionally there was a discrepancy in validating the nic-name
in the rust-based installers (is_ascii_alphabetic also matches upper-case
letters, whereas the perl-regex required [a-z])
Align the validation with the version in pve-common.
Tested by running the installer with the patch applied in TUI mode
(it creates an error for 'ABC', while accepting it without the patch) and
in GUI mode (to verify the error-message mentions lower-case letter).
Stoiko Ivanov (2):
common: pinning: require first character to be lower-case ascii
sys: net: fix error-message for interface names first character
Proxmox/Sys/Net.pm | 2 +-
proxmox-installer-common/src/options.rs | 8 ++++----
test/validate-link-pin-map.pl | 4 ++--
3 files changed, 7 insertions(+), 7 deletions(-)
--
2.47.3
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next reply other threads:[~2025-11-18 15:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-18 15:15 Stoiko Ivanov [this message]
2025-11-18 15:15 ` [pve-devel] [PATCH installer 1/2] common: pinning: require first character to be lower-case ascii Stoiko Ivanov
2025-11-18 15:15 ` [pve-devel] [PATCH installer 2/2] sys: net: fix error-message for interface names first character Stoiko Ivanov
2025-11-18 16:31 ` [pve-devel] applied: [PATCH installer 0/2] nic pinning: require first character to be lower-case Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251118151532.592423-1-s.ivanov@proxmox.com \
--to=s.ivanov@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox