From: Filip Schauer <f.schauer@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH storage 2/4] api: storage status: do not pull OCI image if file already exists
Date: Mon, 17 Nov 2025 18:13:15 +0100 [thread overview]
Message-ID: <20251117171528.262443-3-f.schauer@proxmox.com> (raw)
In-Reply-To: <20251117171528.262443-1-f.schauer@proxmox.com>
This ensures that the API call fails early, before pulling the OCI image
from the registry and then failing to rename the temporary file.
Signed-off-by: Filip Schauer <f.schauer@proxmox.com>
---
src/PVE/API2/Storage/Status.pm | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/PVE/API2/Storage/Status.pm b/src/PVE/API2/Storage/Status.pm
index 96832b9..9fb6141 100644
--- a/src/PVE/API2/Storage/Status.pm
+++ b/src/PVE/API2/Storage/Status.pm
@@ -964,6 +964,8 @@ __PACKAGE__->register_method({
my $path = PVE::Storage::get_vztmpl_dir($cfg, $storage);
PVE::Storage::activate_storage($cfg, $storage);
+ die "refusing to override existing file '$filename'\n" if (-f "$path/$filename");
+
local $SIG{INT} = sub {
unlink "$path/$tmp_filename"
or warn "could not cleanup temporary file: $!"
--
2.47.3
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-11-17 17:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-17 17:13 [pve-devel] [PATCH storage 0/4] OCI registry pull fixes Filip Schauer
2025-11-17 17:13 ` [pve-devel] [PATCH storage 1/4] api: storage status: pull OCI image to temporary file Filip Schauer
2025-11-17 17:13 ` Filip Schauer [this message]
2025-11-17 17:13 ` [pve-devel] [PATCH storage 3/4] api: storage status: add optional OCI image filename parameter Filip Schauer
2025-11-17 18:58 ` Filip Schauer
2025-11-17 17:13 ` [pve-devel] [PATCH storage 4/4] api: storage status: oci-registry-pull: fix incomplete reference regex Filip Schauer
2025-11-17 20:56 ` [pve-devel] applied: [PATCH storage 0/4] OCI registry pull fixes Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251117171528.262443-3-f.schauer@proxmox.com \
--to=f.schauer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox