public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Daniel Kral <d.kral@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH ha-manager v4 13/21] rules: node affinity: define node priority outside hash access
Date: Fri, 14 Nov 2025 12:17:11 +0100	[thread overview]
Message-ID: <20251114111828.160294-14-d.kral@proxmox.com> (raw)
In-Reply-To: <20251114111828.160294-1-d.kral@proxmox.com>

Suggested-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Signed-off-by: Daniel Kral <d.kral@proxmox.com>
Reviewed-by: Michael Köppl <m.koeppl@proxmox.com>
Tested-by: Michael Köppl <m.koeppl@proxmox.com>
---
 src/PVE/HA/Rules/NodeAffinity.pm | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/PVE/HA/Rules/NodeAffinity.pm b/src/PVE/HA/Rules/NodeAffinity.pm
index adef97d0..d98f896d 100644
--- a/src/PVE/HA/Rules/NodeAffinity.pm
+++ b/src/PVE/HA/Rules/NodeAffinity.pm
@@ -276,8 +276,10 @@ sub get_node_affinity : prototype($$$) {
     while (my ($node, $props) = each $node_affinity->{$sid}->{nodes}->%*) {
         next if !defined($online_nodes->{$node}); # node is offline
 
+        my $node_priority = $props->{priority} // 0;
+
         $allowed_nodes->{$node} = 1;
-        $prioritized_nodes->{ $props->{priority} }->{$node} = 1;
+        $prioritized_nodes->{$node_priority}->{$node} = 1;
     }
 
     my $preferred_nodes = {};
-- 
2.47.3



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

  parent reply	other threads:[~2025-11-14 11:19 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-14 11:16 [pve-devel] [PATCH-SERIES ha-manager v4 00/21] HA rules fixes + performance improvements + cleanup Daniel Kral
2025-11-14 11:16 ` [pve-devel] [PATCH ha-manager v4 01/21] config: do not add ignored resources to dependent resources Daniel Kral
2025-11-14 11:17 ` [pve-devel] [PATCH ha-manager v4 02/21] manager: retranslate rules if nodes are added or removed Daniel Kral
2025-11-14 11:17 ` [pve-devel] [PATCH ha-manager v4 03/21] rules: factor out disjoint rules' resource set helper Daniel Kral
2025-11-14 11:17 ` [pve-devel] [PATCH ha-manager v4 04/21] rules: resource affinity: inter-consistency check with merged positive rules Daniel Kral
2025-11-14 11:17 ` [pve-devel] [PATCH ha-manager v4 05/21] rules: add merged positive resource affinity info in global checks Daniel Kral
2025-11-14 11:17 ` [pve-devel] [PATCH ha-manager v4 06/21] rules: make rules sorting optional in foreach_rule helper Daniel Kral
2025-11-14 11:17 ` [pve-devel] [PATCH ha-manager v4 07/21] rename rule's canonicalize stage to transform stage Daniel Kral
2025-11-14 11:17 ` [pve-devel] [PATCH ha-manager v4 08/21] rules: make plugins register transformers instead of plugin_transform Daniel Kral
2025-11-14 11:17 ` [pve-devel] [PATCH ha-manager v4 09/21] rules: node affinity: decouple get_node_affinity helper from Usage class Daniel Kral
2025-11-14 11:17 ` [pve-devel] [PATCH ha-manager v4 10/21] compile ha rules to a more compact representation Daniel Kral
2025-11-14 11:17 ` [pve-devel] [PATCH ha-manager v4 11/21] test: rules: use to_json instead of Data::Dumper for config output Daniel Kral
2025-11-14 11:17 ` [pve-devel] [PATCH ha-manager v4 12/21] test: rules: add compiled config output to rules config test cases Daniel Kral
2025-11-14 11:17 ` Daniel Kral [this message]
2025-11-14 11:17 ` [pve-devel] [PATCH ha-manager v4 14/21] move minimum version check helper to ha tools Daniel Kral
2025-11-14 11:17 ` [pve-devel] [PATCH ha-manager v4 15/21] manager: move group migration cooldown variable into helper Daniel Kral
2025-11-14 11:17 ` [pve-devel] [PATCH ha-manager v4 16/21] api: status: sync active service counting with lrm's helper Daniel Kral
2025-11-14 11:17 ` [pve-devel] [PATCH ha-manager v4 17/21] manager: group migration: " Daniel Kral
2025-11-14 11:17 ` [pve-devel] [PATCH ha-manager v4 18/21] factor out counting of active services into helper Daniel Kral
2025-11-14 11:17 ` [pve-devel] [PATCH ha-manager v4 19/21] tree-wide: remove misused function prototype declaractions Daniel Kral
2025-11-14 11:17 ` [pve-devel] [PATCH ha-manager v4 20/21] rules: fix documentation for inter-rules checker subroutines Daniel Kral
2025-11-14 11:17 ` [pve-devel] [PATCH ha-manager v4 21/21] rules: add documentation about current feasibility check implementations Daniel Kral
2025-11-14 14:09 ` [pve-devel] applied: [PATCH-SERIES ha-manager v4 00/21] HA rules fixes + performance improvements + cleanup Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251114111828.160294-14-d.kral@proxmox.com \
    --to=d.kral@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal