public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Shan Shaji <s.shaji@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH proxmox_login_manager v2 2/4] fix: ui: add more padding around the form in portrait mode
Date: Tue, 11 Nov 2025 15:00:03 +0100	[thread overview]
Message-ID: <20251111140005.41510-3-s.shaji@proxmox.com> (raw)
In-Reply-To: <20251111140005.41510-1-s.shaji@proxmox.com>

portrait mode the margins around the "Origin" field are bit tight. To
fix it, if the orientation is portrait set the horizontal padding to
`12` and in landscape it will be `8`.

The helper text was getting truncated after adding the padding. Inorder
to fix that used `Text` widget.

Signed-off-by: Shan Shaji <s.shaji@proxmox.com>
---
 lib/proxmox_login_form.dart | 18 ++++++++++++------
 1 file changed, 12 insertions(+), 6 deletions(-)

diff --git a/lib/proxmox_login_form.dart b/lib/proxmox_login_form.dart
index e193c57..8f290b4 100644
--- a/lib/proxmox_login_form.dart
+++ b/lib/proxmox_login_form.dart
@@ -72,11 +72,12 @@ class _ProxmoxLoginFormState extends State<ProxmoxLoginForm> {
     if (widget.accessDomains == null) {
       return TextFormField(
         decoration: const InputDecoration(
-            icon: Icon(Icons.vpn_lock),
-            labelText: 'Origin',
-            hintText: 'e.g. 192.168.1.2',
-            helperText:
-                'Protocol (https) and default port (8006 or 443) implied'),
+          icon: Icon(Icons.vpn_lock),
+          labelText: 'Origin',
+          hintText: 'e.g. 192.168.1.2',
+          helper:
+              Text('Protocol (https) and default port (8006 or 443) implied'),
+        ),
         textInputAction: TextInputAction.next,
         controller: widget.originController,
         validator: widget.originValidator,
@@ -325,7 +326,12 @@ class _ProxmoxLoginPageState extends State<ProxmoxLoginPage> {
                     height: MediaQuery.of(context).size.height),
                 child: SafeArea(
                   child: Padding(
-                    padding: const EdgeInsets.all(8.0),
+                    padding: EdgeInsets.symmetric(
+                      horizontal: MediaQuery.maybeOrientationOf(context) ==
+                              Orientation.portrait
+                          ? 12
+                          : 8,
+                    ),
                     child: FutureBuilder<List<PveAccessDomainModel?>?>(
                         future: _accessDomains,
                         builder: (context, snapshot) {
-- 
2.50.1



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


  parent reply	other threads:[~2025-11-11 13:59 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-11 14:00 [pve-devel] [PATCH proxmox_login_manager v2 0/4] fix #6983: ui: make cosmetic changes inside the login screen Shan Shaji
2025-11-11 14:00 ` [pve-devel] [PATCH proxmox_login_manager v2 1/4] fix: ui: disable continue button by default in login form Shan Shaji
2025-11-11 14:00 ` Shan Shaji [this message]
2025-11-11 14:00 ` [pve-devel] [PATCH proxmox_login_manager v2 3/4] fix: ui: remove app bar and stack the close button on body Shan Shaji
2025-11-11 14:00 ` [pve-devel] [PATCH proxmox_login_manager v2 4/4] cleanup: run dart format command to fix formatting Shan Shaji
2025-11-12  9:21 ` [pve-devel] applied: [PATCH proxmox_login_manager v2 0/4] fix #6983: ui: make cosmetic changes inside the login screen Dominik Csapak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251111140005.41510-3-s.shaji@proxmox.com \
    --to=s.shaji@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal