public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Shannon Sterz <s.sterz@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH yew-mobile-gui 3/3] page login: skip consent banner when openid authorization is present
Date: Mon, 10 Nov 2025 13:52:36 +0100	[thread overview]
Message-ID: <20251110125236.247271-4-s.sterz@proxmox.com> (raw)
In-Reply-To: <20251110125236.247271-1-s.sterz@proxmox.com>

improves ux so users don't have to agree to the consent banner twice.

Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
---
 src/pages/page_login.rs | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/src/pages/page_login.rs b/src/pages/page_login.rs
index 7875af3..63fad30 100644
--- a/src/pages/page_login.rs
+++ b/src/pages/page_login.rs
@@ -10,6 +10,7 @@ use pwt::widget::{Button, Column, Row};
 use crate::widgets::TopNavBar;
 
 use proxmox_yew_comp::layout::card::standard_card;
+use proxmox_yew_comp::utils::openid_redirection_authorization;
 use proxmox_yew_comp::{LoginPanel, Markdown};
 
 use proxmox_login::Authentication;
@@ -68,7 +69,9 @@ impl Component for PvePageLogin {
             props.consent_text.as_ref().filter(|t| !t.is_empty())
         };
 
-        let content: Html = if let Some(consent_text) = consent_text {
+        let content: Html = if let Some(consent_text) = consent_text
+            && openid_redirection_authorization().is_none()
+        {
             let card = standard_card(tr!("Consent"), (), ())
                 .class("pwt-scheme-neutral")
                 .with_child(
-- 
2.47.3



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


  parent reply	other threads:[~2025-11-10 12:52 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-10 12:52 [pve-devel] [PATCH yew-mobile-gui 0/3] update to edition 2024 and " Shannon Sterz
2025-11-10 12:52 ` [pve-devel] [PATCH yew-mobile-gui 1/3] update rust edition to 2024 Shannon Sterz
2025-11-10 12:52 ` [pve-devel] [PATCH yew-mobile-gui 2/3] dashboard panel: remove unnecessary binding modifiers Shannon Sterz
2025-11-10 12:52 ` Shannon Sterz [this message]
2025-11-10 13:04 ` [pve-devel] applied: [PATCH yew-mobile-gui 0/3] update to edition 2024 and skip consent banner when openid authorization is present Dietmar Maurer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251110125236.247271-4-s.sterz@proxmox.com \
    --to=s.sterz@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal