public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH/RFC storage 0/1] lvmplugin: improve error handling for saferemove
Date: Tue, 28 Oct 2025 10:49:57 +0100	[thread overview]
Message-ID: <20251028095006.29348-1-f.ebner@proxmox.com> (raw)

This is a follow-up to Alexandre's recently applied series [0].

Ensure that volumes are not automatically removed after a failure to
zero-out to give an admin the possibility to do so manually. The
downside is that "del-.*" volumes might remain left-over, the upside
is that data does not leak upon error.

Also ensure that activation failure of a single volume does not error
out early, but continue with removal of other volumes.

[0]: https://lore.proxmox.com/pve-devel/mailman.253.1761222252.362.pve-devel@lists.proxmox.com/T/

pve-storage:

Fiona Ebner (1):
  lvmplugin: improve error handling for saferemove

 src/PVE/Storage/LVMPlugin.pm | 59 ++++++++++++++++++++----------------
 1 file changed, 33 insertions(+), 26 deletions(-)


Summary over all repositories:
  1 files changed, 33 insertions(+), 26 deletions(-)

-- 
Generated by git-murpp 0.5.0


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


             reply	other threads:[~2025-10-28  9:50 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-28  9:49 Fiona Ebner [this message]
2025-10-28  9:49 ` [pve-devel] [PATCH/RFC storage 1/1] " Fiona Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251028095006.29348-1-f.ebner@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal