From: "Laurențiu Leahu-Vlăducu" <l.leahu-vladucu@proxmox.com>
To: pve-devel@lists.proxmox.com
Cc: Thomas Lamprecht <t.lamprecht@proxmox.com>
Subject: [pve-devel] [PATCH pve-http-server v2] AnyEvent: add timestamps to debug logs
Date: Tue, 21 Oct 2025 16:10:30 +0200 [thread overview]
Message-ID: <20251021141030.185691-1-l.leahu-vladucu@proxmox.com> (raw)
This helps correlate our debug logs with other log files for
easier debugging when making API calls. This might ease debugging
in our enterprise support and forum, or for external developers
who need to debug Proxmox VE.
This patch does add some delay when printing debug logs (pointed out
by Thomas):
elapsed[gettimeofday+strftime,1000000]: 5.730306 s => 5.730306 us/loop
elapsed[strftime, 1000000]: 5.532132 s => 5.532132 us/loop
elapsed[gettimeofday, 1000000]: 100.645 ms => 100.645 ns/loop
However, this only happens when printing debug logs, in which case
it is often expected that software might be slightly slower.
Signed-off-by: Laurențiu Leahu-Vlăducu <l.leahu-vladucu@proxmox.com>
Tested-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Reviewed-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
---
Changes since v1:
* the separator '|' is no longer used after the timestamp
* improved commit message
* added Thomas' T-b and R-b
src/PVE/APIServer/AnyEvent.pm | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/PVE/APIServer/AnyEvent.pm b/src/PVE/APIServer/AnyEvent.pm
index 59bc184..24b298d 100644
--- a/src/PVE/APIServer/AnyEvent.pm
+++ b/src/PVE/APIServer/AnyEvent.pm
@@ -76,7 +76,9 @@ sub dprint {
my ($pkg, $pkgfile, $line, $sub) = caller(1);
$sub =~ s/^(?:.+::)+//;
- print "worker[$$]: $pkg +$line: $sub: $message\n";
+ my ($secs, $microsecs) = gettimeofday();
+ my $timestr = strftime("%F %T", localtime($secs)) . sprintf(".%06d", $microsecs);
+ print "$timestr worker[$$]: $pkg +$line: $sub: $message\n";
}
sub log_request {
--
2.47.3
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next reply other threads:[~2025-10-21 14:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-21 14:10 Laurențiu Leahu-Vlăducu [this message]
2025-10-21 16:20 ` Thomas Lamprecht
2025-10-21 16:50 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251021141030.185691-1-l.leahu-vladucu@proxmox.com \
--to=l.leahu-vladucu@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox