[pve-devel] [PATCH ha-manager v2 2/8] manager: remove redundant add_service_usage_to_node from next_state_recovery

[Daniel Kral <d.kral@proxmox.com>]

Since 5c2eef4b ("account service to source and target during move") a
moving HA resource's load is accounted for on the source and target
nodes.

A HA resource is in the 'recovery' state after a successfully fenced
node and its primary goal becomes to find a recovery node. As soon as a
recovery node is found, the HA resource is moved there. As the previous
node was fenced, there is only load on the recovery node.

The add_service_usage_to_node(...) is redundant at this point as the
subsequent call to change_service_state(...) to either the 'started' or
'request_stop' state will call recompute_online_node_usage(...) and make
the changes to $online_node_usage be discarded immediately.

This calculation will remain true as recompute_online_node_usage(...) in
change_service_state(...) is replaced with a more granular change to
$online_node_usage in a later patch.

Signed-off-by: Daniel Kral <d.kral@proxmox.com>
Reviewed-by: Fiona Ebner <f.ebner@proxmox.com>
---
changes since v1:
 - added info that calculation will hold with later patches
 - added R-b

 src/PVE/HA/Manager.pm | 2 --
 1 file changed, 2 deletions(-)

diff --git a/src/PVE/HA/Manager.pm b/src/PVE/HA/Manager.pm
index 8a1e177d..7e43cfdf 100644
--- a/src/PVE/HA/Manager.pm
+++ b/src/PVE/HA/Manager.pm
@@ -1329,8 +1329,6 @@ sub next_state_recovery {
         $fence_recovery_cleanup->($self, $sid, $fenced_node);
 
         $haenv->steal_service($sid, $sd->{node}, $recovery_node);
-        $self->{online_node_usage}->add_service_usage_to_node($recovery_node, $sid, $recovery_node);
-        $self->{online_node_usage}->add_service_node($sid, $recovery_node);
 
         # NOTE: $sd *is normally read-only*, fencing is the exception
         $cd->{node} = $sd->{node} = $recovery_node;
-- 
2.47.3



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel