public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Maximiliano Sandoval <m.sandoval@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH container/guest-common/qemu-server v3 0/9] fix #1964: add setting to always disable freezing a guest
Date: Tue, 14 Oct 2025 14:27:07 +0200	[thread overview]
Message-ID: <20251014122718.374205-1-m.sandoval@proxmox.com> (raw)

..and add more logging when issuing fsfreeze guest commands.

The setting takes precedence over freeze-fs-on-backup and deprecates the former.

- At the moment taking a snapshot without RAM does not log whether there was a
  freeze/thaw, we add logs when issuing freezes/thaws.
- The patch does result in an extra log line when making a Backup in snapshot mode.

One possible further improvement is to add a message saying that fsfreeze/fsthaw
were skipped due to the config when doing snapshots without RAM.

Differences from v2:
 - Print a message on live clones when fsfreeze is skipped due to config
 - Clean up code a bit
 - rebase
 - Fix a typo

Differences from v1:
 - Add setting to enable/disable fsfreeze commands
 - Change wording in one log message


qemu-server:

Maximiliano Sandoval (7):
  add a guest-fsfreeze qga setting
  block job: mirror: follow guest-fsfreeze setting
  fix #1964: follow guest-fsfreeze setting on check freeze needed
  log when issuing a guest-fsfreeze command
  block job: mirror: reword fsfreeze log entry
  block job: log if fs-freeze is skipped due to config
  deprecate freeze-fs-on-backup qga setting

 src/PVE/QemuConfig.pm          |  5 ++++-
 src/PVE/QemuServer/Agent.pm    | 15 ++++++++++++++-
 src/PVE/QemuServer/BlockJob.pm | 16 ++++++++++++----
 src/PVE/VZDump/QemuServer.pm   |  7 +++++--
 4 files changed, 35 insertions(+), 8 deletions(-)


pve-container:

Maximiliano Sandoval (1):
  log when freezing/thawing filesystem

 src/PVE/LXC/Config.pm | 2 ++
 1 file changed, 2 insertions(+)


qemu-server:

Maximiliano Sandoval (1):
  replication: remove logging when freezing/thawing

 src/PVE/Replication.pm | 2 --
 1 file changed, 2 deletions(-)


Summary over all repositories:
  6 files changed, 37 insertions(+), 10 deletions(-)

-- 
Generated by murpp 0.9.0


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


             reply	other threads:[~2025-10-14 12:28 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-14 12:27 Maximiliano Sandoval [this message]
2025-10-14 12:27 ` [pve-devel] [PATCH qemu-server v3 1/7] add a guest-fsfreeze qga setting Maximiliano Sandoval
2025-10-14 12:27 ` [pve-devel] [PATCH qemu-server v3 2/7] block job: mirror: follow guest-fsfreeze setting Maximiliano Sandoval
2025-10-14 12:27 ` [pve-devel] [PATCH qemu-server v3 3/7] fix #1964: follow guest-fsfreeze setting on check freeze needed Maximiliano Sandoval
2025-10-14 12:27 ` [pve-devel] [PATCH qemu-server v3 4/7] log when issuing a guest-fsfreeze command Maximiliano Sandoval
2025-10-14 12:27 ` [pve-devel] [PATCH qemu-server v3 5/7] block job: mirror: reword fsfreeze log entry Maximiliano Sandoval
2025-10-14 12:27 ` [pve-devel] [PATCH qemu-server v3 6/7] block job: log if fs-freeze is skipped due to config Maximiliano Sandoval
2025-10-14 12:27 ` [pve-devel] [PATCH qemu-server v3 7/7] deprecate freeze-fs-on-backup qga setting Maximiliano Sandoval
2025-10-14 12:27 ` [pve-devel] [PATCH container v3 1/1] log when freezing/thawing filesystem Maximiliano Sandoval
2025-10-14 12:27 ` [pve-devel] [PATCH guest-common v3 1/1] replication: remove logging when freezing/thawing Maximiliano Sandoval

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251014122718.374205-1-m.sandoval@proxmox.com \
    --to=m.sandoval@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal