public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Maximiliano Sandoval <m.sandoval@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH ha-manager 3/9] sim: allow editing static resources of resource
Date: Tue, 14 Oct 2025 11:47:21 +0200	[thread overview]
Message-ID: <20251014094739.209924-4-m.sandoval@proxmox.com> (raw)
In-Reply-To: <20251014094739.209924-1-m.sandoval@proxmox.com>

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
 src/PVE/HA/Sim/RTHardware.pm | 82 +++++++++++++++++++++++++++++++++++-
 1 file changed, 80 insertions(+), 2 deletions(-)

diff --git a/src/PVE/HA/Sim/RTHardware.pm b/src/PVE/HA/Sim/RTHardware.pm
index 28c756e..e46cb91 100644
--- a/src/PVE/HA/Sim/RTHardware.pm
+++ b/src/PVE/HA/Sim/RTHardware.pm
@@ -490,6 +490,75 @@ sub show_service_add_dialog {
     $dialog->destroy();
 }
 
+sub show_service_edit_dialog {
+    my ($self, $sid) = @_;
+
+    my $stats = $self->read_static_service_stats();
+    my $resource_stats = $stats->{$sid}
+        // { maxcpu => $DEFAULT_MAXCPU, maxmemory => $DEFAULT_MAXMEM };
+
+    my $cpu_label = Gtk3::Label->new('CPU Count');
+    $cpu_label->set_hexpand(1);
+    $cpu_label->set_xalign(0);
+
+    my $cpu_count_spin = Gtk3::SpinButton->new_with_range(1.0, 1024, 1.0);
+    $cpu_count_spin->set_value($resource_stats->{maxcpu});
+
+    my $cpu_box = Gtk3::Box->new('horizontal', 6);
+    $cpu_box->add($cpu_label);
+    $cpu_box->add($cpu_count_spin);
+
+    my $memory_label = Gtk3::Label->new('Memory (MiB)');
+    $memory_label->set_hexpand(1);
+    $memory_label->set_xalign(0);
+
+    # There is an arbitrary limit of 10 TiB
+    my $memory_spin = Gtk3::SpinButton->new_with_range(1.0, 10485760.0, 1.0);
+    $memory_spin->set_value($resource_stats->{maxmemory});
+
+    my $memory_box = Gtk3::Box->new('horizontal', 6);
+    $memory_box->add($memory_label);
+    $memory_box->add($memory_spin);
+
+    my $vbox = Gtk3::Box->new('vertical', 6);
+    $vbox->add($cpu_box);
+    $vbox->add($memory_box);
+
+    my $dialog = Gtk3::Dialog->new();
+
+    $dialog->set_title("Migrate $sid");
+    $dialog->set_modal(1);
+    $dialog->set_transient_for($self->{main_window});
+
+    $dialog->add_button("_OK", 'ok');
+
+    my $content_area = $dialog->get_content_area();
+    $content_area->add($vbox);
+    $vbox->set_margin_start(12);
+    $vbox->set_margin_end(12);
+    $vbox->set_margin_top(12);
+    $vbox->set_margin_bottom(12);
+
+    $dialog->show_all();
+
+    $dialog->signal_connect(
+        'response' => sub {
+            my ($dialog, $response) = @_;
+
+            if ($response eq 'ok') {
+                $self->set_static_service_stats(
+                    $sid,
+                    {
+                        maxcpu => $cpu_count_spin->get_value(),
+                        maxmemory => $memory_spin->get_value(),
+                    },
+                );
+            }
+            $dialog->close();
+        },
+    );
+}
+
 sub show_service_delete_dialog {
     my ($self, $sid) = @_;
 
@@ -659,8 +728,17 @@ sub new_service_gui_entry {
     $sgrid->attach($w, 4, $row, 1, 1);
     $self->{service_gui}->{$sid}->{status_label} = $w;
 
+    my $edit_button = Gtk3::Button->new_from_icon_name('document-edit', 1);
+    $edit_button->set_tooltip_text('Edit static resources');
+    $sgrid->attach($edit_button, 5, $row, 1, 1);
+    $edit_button->signal_connect(
+        clicked => sub {
+            $self->show_service_edit_dialog($sid);
+        },
+    );
+
     $w = Gtk3::Button->new_from_icon_name('edit-delete', 1);
-    $sgrid->attach($w, 5, $row, 1, 1);
+    $sgrid->attach($w, 6, $row, 1, 1);
     $w->signal_connect(
         clicked => sub {
             $self->show_service_delete_dialog($sid);
@@ -699,7 +777,7 @@ sub create_service_control {
     }
 
     $w = Gtk3::Button->new_from_icon_name('list-add', 1);
-    $sgrid->attach($w, 5, $row, 1, 1);
+    $sgrid->attach($w, 6, $row, 1, 1);
     $w->signal_connect(
         clicked => sub {
             $self->show_service_add_dialog();
-- 
2.47.3



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


  parent reply	other threads:[~2025-10-14  9:47 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-14  9:47 [pve-devel] [PATCH ha-manager 0/9] allow setting crs and service static resources Maximiliano Sandoval
2025-10-14  9:47 ` [pve-devel] [PATCH ha-manager 1/9] sim: add command to set static service stats Maximiliano Sandoval
2025-10-14  9:47 ` [pve-devel] [PATCH ha-manager 2/9] sim: add UI to set resource stats for new guests Maximiliano Sandoval
2025-10-14  9:47 ` Maximiliano Sandoval [this message]
2025-10-14 10:00   ` [pve-devel] [PATCH ha-manager 3/9] sim: allow editing static resources of resource Maximiliano Sandoval
2025-10-14  9:47 ` [pve-devel] [PATCH ha-manager 4/9] sim: add helper to store datacenter configuration Maximiliano Sandoval
2025-10-14  9:47 ` [pve-devel] [PATCH ha-manager 5/9] sim: allow configuring " Maximiliano Sandoval
2025-10-14  9:47 ` [pve-devel] [PATCH ha-manager 6/9] sim: add method to persist current state Maximiliano Sandoval
2025-10-14  9:47 ` [pve-devel] [PATCH ha-manager 7/9] sim: add button to persist state to header bar Maximiliano Sandoval
2025-10-14  9:47 ` [pve-devel] [PATCH ha-manager 8/9] sim: set default cpu count and memory on new nodes Maximiliano Sandoval
2025-10-14  9:47 ` [pve-devel] [PATCH ha-manager 9/9] gitignore: ignore build directory Maximiliano Sandoval

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251014094739.209924-4-m.sandoval@proxmox.com \
    --to=m.sandoval@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal