[pve-devel] [PATCH pve-manager] fix #6897: ui: add hint that lxc nesting is usually required

[pve-devel] [PATCH pve-manager] fix #6897: ui: add hint that lxc nesting is usually required

[Robert Obkircher]

Modern distributions require nesting to access /sys and /proc.
Someone ran into issues when trying to disable it and suggested
adding a warning on the Web UI.

Fixes: https://bugzilla.proxmox.com/show_bug.cgi?id=6897
Signed-off-by: Robert Obkircher <r.obkircher@proxmox.com>
---
 www/manager6/lxc/CreateWizard.js | 1 +
 www/manager6/lxc/FeaturesEdit.js | 1 +
 2 files changed, 2 insertions(+)

diff --git a/www/manager6/lxc/CreateWizard.js b/www/manager6/lxc/CreateWizard.js
index 0f6fcce8..e8093c0a 100644
--- a/www/manager6/lxc/CreateWizard.js
+++ b/www/manager6/lxc/CreateWizard.js
@@ -81,6 +81,7 @@ Ext.define('PVE.lxc.CreateWizard', {
                         disabled: '{!unprivileged}',
                     },
                     fieldLabel: gettext('Nesting'),
+                    boxLabel: gettext('required for many distributions'),
                 },
             ],
             column2: [
diff --git a/www/manager6/lxc/FeaturesEdit.js b/www/manager6/lxc/FeaturesEdit.js
index 271f1cc3..df33e67c 100644
--- a/www/manager6/lxc/FeaturesEdit.js
+++ b/www/manager6/lxc/FeaturesEdit.js
@@ -36,6 +36,7 @@ Ext.define('PVE.lxc.FeaturesInputPanel', {
             xtype: 'proxmoxcheckbox',
             fieldLabel: gettext('Nesting'),
             name: 'nesting',
+            boxLabel: gettext('required for many distributions'),
         },
         {
             xtype: 'proxmoxcheckbox',
-- 
2.47.3



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH pve-manager] fix #6897: ui: add hint that lxc nesting is usually required

[Thomas Lamprecht]

Am 13.10.25 um 12:03 schrieb Robert Obkircher:
> Modern distributions require nesting to access /sys and /proc.
> Someone ran into issues when trying to disable it and suggested
> adding a warning on the Web UI.

Thanks for your patch, the changes track besides maybe some wording
improvements, but not sure how much this really helps, as it probably
would only guard against unticking the "nesting" checkbox on CT
creation, but not be visible when one updates a existing old CT without
nesting from inside the CT to a newer distro release that then requires
nesting. I asked some follow-up questions to the reporter on BZ  to try
to better understand what they meant and what would have helped them.

> 
> Fixes: https://bugzilla.proxmox.com/show_bug.cgi?id=6897
> Signed-off-by: Robert Obkircher <r.obkircher@proxmox.com>
> ---
>  www/manager6/lxc/CreateWizard.js | 1 +
>  www/manager6/lxc/FeaturesEdit.js | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/www/manager6/lxc/CreateWizard.js b/www/manager6/lxc/CreateWizard.js
> index 0f6fcce8..e8093c0a 100644
> --- a/www/manager6/lxc/CreateWizard.js
> +++ b/www/manager6/lxc/CreateWizard.js
> @@ -81,6 +81,7 @@ Ext.define('PVE.lxc.CreateWizard', {
>                          disabled: '{!unprivileged}',
>                      },
>                      fieldLabel: gettext('Nesting'),
> +                    boxLabel: gettext('required for many distributions'),
>                  },
>              ],
>              column2: [
> diff --git a/www/manager6/lxc/FeaturesEdit.js b/www/manager6/lxc/FeaturesEdit.js
> index 271f1cc3..df33e67c 100644
> --- a/www/manager6/lxc/FeaturesEdit.js
> +++ b/www/manager6/lxc/FeaturesEdit.js
> @@ -36,6 +36,7 @@ Ext.define('PVE.lxc.FeaturesInputPanel', {
>              xtype: 'proxmoxcheckbox',
>              fieldLabel: gettext('Nesting'),
>              name: 'nesting',
> +            boxLabel: gettext('required for many distributions'),
>          },
>          {
>              xtype: 'proxmoxcheckbox',



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel