From: Nicolas Frey <n.frey@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH pve-common v2] cli: fix #6762: only copy properties if defined
Date: Tue, 7 Oct 2025 17:16:49 +0200 [thread overview]
Message-ID: <20251007151649.163255-1-n.frey@proxmox.com> (raw)
Adds a defined check to the copy, as to not result in the following
error:
~# pveceph status Can't use an undefined value as a HASH reference at
/usr/share/perl5/PVE/CLIHandler.pm line 455, <DATA> line 960.
Pressing double tab after status produces the above message.
Fixes: https://bugzilla.proxmox.com/show_bug.cgi?id=6762
Signed-off-by: Nicolas Frey <n.frey@proxmox.com>
---
src/PVE/CLIHandler.pm | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/src/PVE/CLIHandler.pm b/src/PVE/CLIHandler.pm
index 89cb7b7..93b6d78 100644
--- a/src/PVE/CLIHandler.pm
+++ b/src/PVE/CLIHandler.pm
@@ -455,7 +455,10 @@ my $print_bash_completion = sub {
my $info = $class->map_method_by_name($name);
- my $prop = { %{ $info->{parameters}->{properties} } }; # copy
+ my $prop;
+ if (defined(my $properties = $info->{parameters}->{properties})) {
+ $prop = { $properties->%* }; # clone
+ }
$prop = { %$prop, %$formatter_properties } if $formatter_properties;
my $print_parameter_completion = sub {
--
2.47.3
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next reply other threads:[~2025-10-07 15:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-07 15:16 Nicolas Frey [this message]
2025-10-08 19:41 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251007151649.163255-1-n.frey@proxmox.com \
--to=n.frey@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox