public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] [PATCH manager v2 0/3] add option to add guest as HA resource
@ 2025-10-07 12:41 Michael Köppl
  2025-10-07 12:41 ` [pve-devel] [PATCH manager v2 1/3] qemu: create: add checkbox for creating HA resource upon VM creation Michael Köppl
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Michael Köppl @ 2025-10-07 12:41 UTC (permalink / raw)
  To: pve-devel

This patch series adds checkboxes to the CreateWizard and Restore
dialogs that allow users to add a new or restored guest as a HA resource
right away. This is an adapted version of the pve-manager patches in v1
[0].

Changes since v1:
- remove patches that were already applied
- move checkboxes in the CreateWizard dialogs to the General section (as
  a result, the value of ha-managed will also be shown in the summary)

[0] https://lore.proxmox.com/pve-devel/20251006155233.267374-1-m.koeppl@proxmox.com/

pve-manager:

Michael Köppl (3):
  qemu: create: add checkbox for creating HA resource upon VM creation
  lxc: create: add checkbox for creating HA resource upon CT creation
  ui: restore: add checkbox for adding HA resource upon restore of guest

 www/manager6/lxc/CreateWizard.js  |  7 +++++++
 www/manager6/qemu/CreateWizard.js |  7 +++++++
 www/manager6/window/Restore.js    | 12 ++++++++++++
 3 files changed, 26 insertions(+)


Summary over all repositories:
  3 files changed, 26 insertions(+), 0 deletions(-)

-- 
Generated by git-murpp 0.8.0


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [pve-devel] [PATCH manager v2 1/3] qemu: create: add checkbox for creating HA resource upon VM creation
  2025-10-07 12:41 [pve-devel] [PATCH manager v2 0/3] add option to add guest as HA resource Michael Köppl
@ 2025-10-07 12:41 ` Michael Köppl
  2025-10-07 12:41 ` [pve-devel] [PATCH manager v2 2/3] lxc: create: add checkbox for creating HA resource upon CT creation Michael Köppl
  2025-10-07 12:41 ` [pve-devel] [PATCH manager v2 3/3] ui: restore: add checkbox for adding HA resource upon restore of guest Michael Köppl
  2 siblings, 0 replies; 4+ messages in thread
From: Michael Köppl @ 2025-10-07 12:41 UTC (permalink / raw)
  To: pve-devel

The new checkbox allows users to create a HA resource for the VM right
away. The 'state' of the HA resource will match the value of the "Start
after creation" checkbox.

Signed-off-by: Michael Köppl <m.koeppl@proxmox.com>
---
 www/manager6/qemu/CreateWizard.js | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/www/manager6/qemu/CreateWizard.js b/www/manager6/qemu/CreateWizard.js
index a10b9c0af..bbbdd7639 100644
--- a/www/manager6/qemu/CreateWizard.js
+++ b/www/manager6/qemu/CreateWizard.js
@@ -96,6 +96,13 @@ Ext.define('PVE.qemu.CreateWizard', {
                     fieldLabel: gettext('Name'),
                     allowBlank: true,
                 },
+                {
+                    xtype: 'proxmoxcheckbox',
+                    name: 'ha-managed',
+                    uncheckedValue: 0,
+                    defaultValue: 0,
+                    fieldLabel: gettext('Add as HA resource'),
+                },
             ],
             column2: [
                 {
-- 
2.47.3



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [pve-devel] [PATCH manager v2 2/3] lxc: create: add checkbox for creating HA resource upon CT creation
  2025-10-07 12:41 [pve-devel] [PATCH manager v2 0/3] add option to add guest as HA resource Michael Köppl
  2025-10-07 12:41 ` [pve-devel] [PATCH manager v2 1/3] qemu: create: add checkbox for creating HA resource upon VM creation Michael Köppl
@ 2025-10-07 12:41 ` Michael Köppl
  2025-10-07 12:41 ` [pve-devel] [PATCH manager v2 3/3] ui: restore: add checkbox for adding HA resource upon restore of guest Michael Köppl
  2 siblings, 0 replies; 4+ messages in thread
From: Michael Köppl @ 2025-10-07 12:41 UTC (permalink / raw)
  To: pve-devel

The new checkbox allows users to create a HA resource for the CT right
away. The 'state' of the HA resource will match the value of the "Start
after creation" checkbox.

Signed-off-by: Michael Köppl <m.koeppl@proxmox.com>
---
 www/manager6/lxc/CreateWizard.js | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/www/manager6/lxc/CreateWizard.js b/www/manager6/lxc/CreateWizard.js
index 0f6fcce8d..475779e6b 100644
--- a/www/manager6/lxc/CreateWizard.js
+++ b/www/manager6/lxc/CreateWizard.js
@@ -82,6 +82,13 @@ Ext.define('PVE.lxc.CreateWizard', {
                     },
                     fieldLabel: gettext('Nesting'),
                 },
+                {
+                    xtype: 'proxmoxcheckbox',
+                    name: 'ha-managed',
+                    uncheckedValue: 0,
+                    defaultValue: 0,
+                    fieldLabel: gettext('Add as HA resource'),
+                },
             ],
             column2: [
                 {
-- 
2.47.3



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [pve-devel] [PATCH manager v2 3/3] ui: restore: add checkbox for adding HA resource upon restore of guest
  2025-10-07 12:41 [pve-devel] [PATCH manager v2 0/3] add option to add guest as HA resource Michael Köppl
  2025-10-07 12:41 ` [pve-devel] [PATCH manager v2 1/3] qemu: create: add checkbox for creating HA resource upon VM creation Michael Köppl
  2025-10-07 12:41 ` [pve-devel] [PATCH manager v2 2/3] lxc: create: add checkbox for creating HA resource upon CT creation Michael Köppl
@ 2025-10-07 12:41 ` Michael Köppl
  2 siblings, 0 replies; 4+ messages in thread
From: Michael Köppl @ 2025-10-07 12:41 UTC (permalink / raw)
  To: pve-devel

Matching the checkbox in the CreateWizard dialogs for VMs and CTs, add
the option to create a HA resource when restoring a guest.

Signed-off-by: Michael Köppl <m.koeppl@proxmox.com>
---
 www/manager6/window/Restore.js | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/www/manager6/window/Restore.js b/www/manager6/window/Restore.js
index 690116df6..e3155f52d 100644
--- a/www/manager6/window/Restore.js
+++ b/www/manager6/window/Restore.js
@@ -41,6 +41,9 @@ Ext.define('PVE.window.Restore', {
             if (values.start && !values['live-restore']) {
                 params.start = 1;
             }
+            if (values['ha-managed']) {
+                params['ha-managed'] = 1;
+            }
             if (values['live-restore']) {
                 params['live-restore'] = 1;
             }
@@ -240,6 +243,15 @@ Ext.define('PVE.window.Restore', {
                         labelWidth: 105,
                         checked: false,
                     },
+                    {
+                        xtype: 'proxmoxcheckbox',
+                        name: 'ha-managed',
+                        reference: 'ha-managed',
+                        flex: 1,
+                        fieldLabel: gettext('Add as HA resource'),
+                        labelWidth: 120,
+                        checked: false,
+                    },
                 ],
             },
         ];
-- 
2.47.3



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2025-10-07 12:42 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-10-07 12:41 [pve-devel] [PATCH manager v2 0/3] add option to add guest as HA resource Michael Köppl
2025-10-07 12:41 ` [pve-devel] [PATCH manager v2 1/3] qemu: create: add checkbox for creating HA resource upon VM creation Michael Köppl
2025-10-07 12:41 ` [pve-devel] [PATCH manager v2 2/3] lxc: create: add checkbox for creating HA resource upon CT creation Michael Köppl
2025-10-07 12:41 ` [pve-devel] [PATCH manager v2 3/3] ui: restore: add checkbox for adding HA resource upon restore of guest Michael Köppl

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal