From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager 1/1] ui: disk storage selector: use new api return format
Date: Mon, 6 Oct 2025 13:24:04 +0200 [thread overview]
Message-ID: <20251006112409.2141871-4-d.csapak@proxmox.com> (raw)
In-Reply-To: <20251006112409.2141871-1-d.csapak@proxmox.com>
since that will be used in the future. For compatibility with older
nodes, keep the old logic around.
No functional change intended.
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
www/manager6/form/DiskStorageSelector.js | 20 ++++++++++++++++----
1 file changed, 16 insertions(+), 4 deletions(-)
diff --git a/www/manager6/form/DiskStorageSelector.js b/www/manager6/form/DiskStorageSelector.js
index ec22ef58..edfdfad4 100644
--- a/www/manager6/form/DiskStorageSelector.js
+++ b/www/manager6/form/DiskStorageSelector.js
@@ -58,16 +58,28 @@ Ext.define('PVE.form.DiskStorageSelector', {
}
let validFormats = {};
- let selectFormat = 'raw';
- if (rec.data.format) {
- validFormats = rec.data.format[0]; // 0 is the formats, 1 the default in the backend
+ let defaultFormat = 'raw';
+ let selectFormat = defaultFormat;
+ if (rec.data.formats) {
+ for (const format of rec.data.formats.supported) {
+ validFormats[format] = true;
+ }
+ defaultFormat = rec.data.formats.default;
+ } else if (rec.data.format) {
+ // legacy api, just for compatibility
+ // 0 is the formats, 1 the default in the backend
+ validFormats = rec.data.format[0];
+ defaultFormat = rec.data.format[1];
+ }
+
+ if (Object.keys(validFormats).length > 0) {
delete validFormats.subvol; // we never need subvol in the gui
if (validFormats.qcow2) {
selectFormat = 'qcow2';
} else if (validFormats.raw) {
selectFormat = 'raw';
} else {
- selectFormat = rec.data.format[1];
+ selectFormat = defaultFormat;
}
}
--
2.47.3
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2025-10-06 11:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-06 11:24 [pve-devel] [PATCH manager/storage 0/3] Improve return schema for storage listing Dominik Csapak
2025-10-06 11:24 ` [pve-devel] [PATCH storage 1/2] api: try to add more return schema information Dominik Csapak
2025-10-06 11:24 ` [pve-devel] [PATCH storage 2/2] api: list: return 'formats' info in a better structured way Dominik Csapak
2025-10-06 11:24 ` Dominik Csapak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251006112409.2141871-4-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox