From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH widget-toolkit] window: acme account: hide e-mail field if it does not exist
Date: Thu, 2 Oct 2025 13:17:25 +0200 [thread overview]
Message-ID: <20251002112528.3128880-1-d.csapak@proxmox.com> (raw)
it seems that currently, the account information returned by letsencrypt
does not include the contact anymore, so there is no 'contact' field in
the 'account' property.
To not trip up the ui, only optionally read that out, and hide the field
completely if it does not exist.
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
I looked in the backend, we save the 'account' object verbatim from the
api response, and the RFC [0] says it should have a contact field, but
it's not there in my tests with the staging + normal api, so not sure
if this is the right fix.
0: https://www.rfc-editor.org/rfc/rfc8555#section-9.7.1
src/window/ACMEAccount.js | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/window/ACMEAccount.js b/src/window/ACMEAccount.js
index 095e674..939ddf2 100644
--- a/src/window/ACMEAccount.js
+++ b/src/window/ACMEAccount.js
@@ -191,10 +191,11 @@ Ext.define('Proxmox.window.ACMEAccountView', {
me.load({
success: function (response) {
var data = response.result.data;
- data.email = data.account.contact[0];
+ data.email = data.account.contact?.[0];
data.createdAt = data.account.createdAt;
data.status = data.account.status;
me.setValues(data);
+ me.down('field[name=email]').setHidden(!data.email);
},
});
},
--
2.47.3
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
reply other threads:[~2025-10-02 11:25 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251002112528.3128880-1-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox