public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Nicolas Frey <n.frey@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH pve-storage] fix #6450: add file-checksum endpoint to storage API
Date: Mon, 29 Sep 2025 11:35:55 +0200	[thread overview]
Message-ID: <20250929093555.86352-1-n.frey@proxmox.com> (raw)

The storage API endpoint now supports an optional 'checksum' parameter.
If set, the checksum is calculated using one of the hashing algorithms
listed in the enum and returned in the 'checksum' return property.

Fixes: https://bugzilla.proxmox.com/show_bug.cgi?id=6450

Signed-off-by: Nicolas Frey <n.frey@proxmox.com>
---
 src/PVE/API2/Storage/Content.pm | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/src/PVE/API2/Storage/Content.pm b/src/PVE/API2/Storage/Content.pm
index 1fe7303..ea60589 100644
--- a/src/PVE/API2/Storage/Content.pm
+++ b/src/PVE/API2/Storage/Content.pm
@@ -306,6 +306,12 @@ __PACKAGE__->register_method({
                 description => "Volume identifier",
                 type => 'string',
             },
+            checksum => {
+                description => 'The algorithm to calculate the checksum of the file.',
+                enum => [qw(sha512 sha384 sha256 sha224 sha1 md5)],
+                type => 'string',
+                optional => 1,
+            }
         },
     },
     returns => {
@@ -340,6 +346,11 @@ __PACKAGE__->register_method({
                 type => 'boolean',
                 optional => 1,
             },
+            checksum => {
+                description => 'The checksum of the file.',
+                type => 'string',
+                optional => 1,
+            }
         },
     },
     code => sub {
@@ -376,6 +387,11 @@ __PACKAGE__->register_method({
             warn $@ if $@;
         }
 
+        if (exists $param->{checksum}) {
+            print "calculating checksum...\n";
+            $entry->{checksum} = PVE::Tools::get_file_hash($param->{checksum}, $path);
+        }
+
         return $entry;
     },
 });
-- 
2.47.3


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


                 reply	other threads:[~2025-09-29  9:35 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250929093555.86352-1-n.frey@proxmox.com \
    --to=n.frey@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal