public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Stefan Hanreich <s.hanreich@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH proxmox{-ve-rs, -firewall} 0/4] Fix ipfilters in proxmox-firewall
Date: Thu, 25 Sep 2025 12:05:05 +0200	[thread overview]
Message-ID: <20250925100514.130484-1-s.hanreich@proxmox.com> (raw)

This patch series addresses two issues with ipfilters:

* containers would have the wrong CIDR inserted into the auto-generated ipfilter
  ipsets
* The nomatch logic isn't working correctly, due to wrong inversion of logic,
  leading to ipfilters not working at all

Including the rustfmt patch here as well, instead of separately since we touch
some of the imports that get changed there - leading to conflicts on applying
otherwise.

proxmox-ve-rs:

Stefan Hanreich (1):
  config: guest: store network devices in BTreeMap

 proxmox-ve-config/src/guest/vm.rs | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)


proxmox-firewall:

Stefan Hanreich (3):
  run rustfmt
  ipfilter: fix wrong entries for containers
  fix #6336: fix ipfilter matching logic

 proxmox-firewall/src/config.rs                |   6 +-
 proxmox-firewall/src/firewall.rs              |  16 +-
 proxmox-firewall/src/object.rs                |   6 +-
 proxmox-firewall/src/rule.rs                  | 155 +++++--
 proxmox-firewall/tests/input/100.conf         |   1 +
 .../integration_tests__firewall.snap          | 416 ++++++++++++++++++
 6 files changed, 559 insertions(+), 41 deletions(-)


Summary over all repositories:
  7 files changed, 563 insertions(+), 45 deletions(-)

-- 
Generated by git-murpp 0.8.0

_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


             reply	other threads:[~2025-09-25 10:05 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-25 10:05 Stefan Hanreich [this message]
2025-09-25 10:05 ` [pve-devel] [PATCH proxmox-ve-rs 1/1] config: guest: store network devices in BTreeMap Stefan Hanreich
2025-09-25 10:05 ` [pve-devel] [PATCH proxmox-firewall 1/3] run rustfmt Stefan Hanreich
2025-09-25 10:05 ` [pve-devel] [PATCH proxmox-firewall 2/3] ipfilter: fix wrong entries for containers Stefan Hanreich
2025-09-25 10:05 ` [pve-devel] [PATCH proxmox-firewall 3/3] fix #6336: fix ipfilter matching logic Stefan Hanreich
2025-09-25 12:22 ` [pve-devel] superseded: [PATCH proxmox{-ve-rs, -firewall} 0/4] Fix ipfilters in proxmox-firewall Stefan Hanreich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250925100514.130484-1-s.hanreich@proxmox.com \
    --to=s.hanreich@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal