From: "Michael Köppl" <m.koeppl@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH FOLLOW-UP manager/widget-toolkit 0/2] replace SafeDestroy
Date: Wed, 24 Sep 2025 18:17:12 +0200 [thread overview]
Message-ID: <20250924161714.434858-1-m.koeppl@proxmox.com> (raw)
This is a follow-up to another series implementing an additional purge
param for resource removal [0].
The ConfirmRemoveDialog window covers the SafeDestroy window's
functionality, but makes it more general-purpose/flexible. It can be
used for both yes/no dialog as well as the SafeDestroy dialogs already
used for guests/storages. The reason for adding ConfirmRemoveDialog was
that Ext.Msg.MessageBox is not properly extendable and simply adding an
additional dialog would result in duplicate functionality covered in
both SafeDestroy and ConfirmRemoveDialog. Thus, replace SafeDestroy with
ConfirmRemoveDialog.
[0] https://lore.proxmox.com/pve-devel/20250924160747.430018-1-m.koeppl@proxmox.com/
proxmox-widget-toolkit:
Michael Köppl (1):
window: remove SafeDestroy
src/Makefile | 1 -
src/window/SafeDestroy.js | 207 --------------------------------------
2 files changed, 208 deletions(-)
delete mode 100644 src/window/SafeDestroy.js
pve-manager:
Michael Köppl (1):
ui: replace SafeDestroy with ConfirmRemoveDialog
www/manager6/window/SafeDestroyGuest.js | 26 ++++++++++++++++++++++-
www/manager6/window/SafeDestroyStorage.js | 23 +++++++++++++++++++-
2 files changed, 47 insertions(+), 2 deletions(-)
Summary over all repositories:
4 files changed, 47 insertions(+), 210 deletions(-)
--
Generated by git-murpp 0.8.0
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next reply other threads:[~2025-09-24 16:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-24 16:17 Michael Köppl [this message]
2025-09-24 16:17 ` [pve-devel] [PATCH FOLLOW-UP widget-toolkit 1/1] window: remove SafeDestroy Michael Köppl
2025-09-24 16:17 ` [pve-devel] [PATCH FOLLOW-UP manager 1/1] ui: replace SafeDestroy with ConfirmRemoveDialog Michael Köppl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250924161714.434858-1-m.koeppl@proxmox.com \
--to=m.koeppl@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox