public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Shannon Sterz <s.sterz@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH installer v2 1/3] install: don't select a debian mirror based on the country anymore
Date: Mon, 22 Sep 2025 11:08:54 +0200	[thread overview]
Message-ID: <20250922090855.58508-3-s.sterz@proxmox.com> (raw)
In-Reply-To: <20250922090855.58508-2-s.sterz@proxmox.com>

newer isos ship with new deb822 style repository configurations in
`/etc/apt/sources.list.d/debian.sources` which already use the now
prefered cdn [1]. since setting a mirror like this does not work
anymore due to this change, just remove it to keep using the prefered
cdn.

[1]:
https://www.debian.org/releases/trixie/release-notes/upgrading.en.html#adding-apt-internet-sources

Reviewed-by: Fiona Ebner <f.ebner@proxmox.com>
Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
---
 Proxmox/Install.pm | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/Proxmox/Install.pm b/Proxmox/Install.pm
index 2ebd376..b42d2f0 100644
--- a/Proxmox/Install.pm
+++ b/Proxmox/Install.pm
@@ -1315,12 +1315,6 @@ _EOD
 
         my $country = Proxmox::Install::Config::get_country();
 
-        # set apt mirror
-        if (my $mirror = $iso_env->{locales}->{country}->{$country}->{mirror}) {
-            my $fn = "$targetdir/etc/apt/sources.list";
-            syscmd("sed -i 's/ftp\\.debian\\.org/$mirror/' '$fn'");
-        }
-
         # create extended_states for apt (avoid cron job warning if that
         # file does not exist)
         file_write_all("$targetdir/var/lib/apt/extended_states", '');
-- 
2.47.3



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


  reply	other threads:[~2025-09-22  9:10 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-22  9:08 [pve-devel] [PATCH installer v2 0/3] remove mirror selection from installer Shannon Sterz
2025-09-22  9:08 ` Shannon Sterz [this message]
2025-09-22  9:08 ` [pve-devel] [PATCH installer v2 2/3] country.pl: remove generating mirror information Shannon Sterz
2025-09-22 10:33   ` Christoph Heiss
2025-09-22 12:08     ` Shannon Sterz
2025-09-22  9:08 ` [pve-devel] [PATCH installer v2 3/3] html/country: update explanatory text to not mention setting a mirror Shannon Sterz
2025-09-22 12:12 ` [pve-devel] Superseded: Re: [PATCH installer v2 0/3] remove mirror selection from installer Shannon Sterz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250922090855.58508-3-s.sterz@proxmox.com \
    --to=s.sterz@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal