public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: "Michael Köppl" <m.koeppl@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager 1/1] ui: ha: rules: make status icon unclickable if there are no errors
Date: Fri, 19 Sep 2025 17:29:01 +0200	[thread overview]
Message-ID: <20250919152901.291068-3-m.koeppl@proxmox.com> (raw)
In-Reply-To: <20250919152901.291068-1-m.koeppl@proxmox.com>

The check icon should not be clickable since it is misleading if
clicking it triggers no action, so add a class to the element that
disables pointer events if there is no error.

Signed-off-by: Michael Köppl <m.koeppl@proxmox.com>
---
 www/manager6/ha/Rules.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/www/manager6/ha/Rules.js b/www/manager6/ha/Rules.js
index b2c510d69..1b4fc7148 100644
--- a/www/manager6/ha/Rules.js
+++ b/www/manager6/ha/Rules.js
@@ -148,7 +148,7 @@ Ext.define('PVE.ha.RulesBaseView', {
                             getClass: (value) =>
                                 Object.keys(value ?? {}).length
                                     ? 'fa fa-exclamation-triangle'
-                                    : 'fa fa-check',
+                                    : 'fa fa-check pmx-unclickable',
                         },
                     ],
                 },
-- 
2.47.3



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

      parent reply	other threads:[~2025-09-19 15:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-19 15:28 [pve-devel] [PATCH manager/widget-toolkit 0/2] make rule status checkmark Michael Köppl
2025-09-19 15:29 ` [pve-devel] [PATCH widget-toolkit 1/1] css: add class for making elements unclickable Michael Köppl
2025-09-19 15:29 ` Michael Köppl [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250919152901.291068-3-m.koeppl@proxmox.com \
    --to=m.koeppl@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal