From: Anton Iacobaeus <anton.iacobaeus@canarybit.eu>
To: pve-devel@lists.proxmox.com
Cc: Anton Iacobaeus <anton.iacobaeus@canarybit.eu>,
Philipp Giersfeld <philipp.giersfeld@canarybit.eu>
Subject: [pve-devel] [PATCH qemu-server 2/3] Add check for TDX support
Date: Tue, 16 Sep 2025 09:52:52 +0200 [thread overview]
Message-ID: <20250916075406.33084-10-anton.iacobaeus@canarybit.eu> (raw)
In-Reply-To: <20250916075406.33084-2-anton.iacobaeus@canarybit.eu>
From: Philipp Giersfeld <philipp.giersfeld@canarybit.eu>
Check whether TDX is enabled on this machine. Instead of using CPUID
like AMD SEV, Intel TDX enablement can be verified by reading an MSR
(https://cc-enabling.trustedservices.intel.com/intel-tdx-enabling-guide/05/host_os_setup/).
Signed-off-by: Philipp Giersfeld <philipp.giersfeld@canarybit.eu>
Signed-off-by: Anton Iacobaeus <anton.iacobaeus@canarybit.eu>
---
.../query-machine-capabilities.c | 56 ++++++++++++++++++-
src/usr/modules-load.conf | 1 +
2 files changed, 56 insertions(+), 1 deletion(-)
diff --git a/src/query-machine-capabilities/query-machine-capabilities.c b/src/query-machine-capabilities/query-machine-capabilities.c
index 0c522afc..913d15c5 100644
--- a/src/query-machine-capabilities/query-machine-capabilities.c
+++ b/src/query-machine-capabilities/query-machine-capabilities.c
@@ -4,6 +4,9 @@
#include <sys/stat.h>
#include <errno.h>
#include <string.h>
+#include <stdlib.h>
+#include <unistd.h>
+#include <fcntl.h>
#define eprintf(...) fprintf(stderr, __VA_ARGS__)
@@ -15,11 +18,49 @@ typedef struct {
bool sev_support;
bool sev_es_support;
bool sev_snp_support;
+ bool tdx_support;
uint8_t cbitpos;
uint8_t reduced_phys_bits;
} cpu_caps_t;
+int read_msr(uint32_t msr_index, unsigned int *value) {
+ int64_t data;
+ char* msr_file_name = "/dev/cpu/0/msr";
+ int fd;
+
+ fd = open(msr_file_name, O_RDONLY);
+ if (fd < 0) {
+ if (errno == ENXIO) {
+ fprintf(stderr, "rdmsr: No CPU 0\n");
+ exit(2);
+ } else if (errno == EIO) {
+ fprintf(stderr, "rdmsr: CPU oesn't support MSRs\n");
+ exit(3);
+ } else {
+ perror("rdmsr: open");
+ exit(127);
+ }
+ }
+
+ if (pread(fd, &data, sizeof data, msr_index) != sizeof data) {
+ if (errno == EIO) {
+ fprintf(stderr, "rdmsr: CPU cannot read MSR 0x%08x\n", msr_index);
+ exit(4);
+ } else {
+ perror("rdmsr: pread");
+ exit(127);
+ }
+ }
+
+
+ *value = data;
+
+ close(fd);
+ return 0;
+}
+
+
void query_cpu_capabilities(cpu_caps_t *res) {
uint32_t eax, ebx, ecx, edx;
@@ -37,6 +78,15 @@ void query_cpu_capabilities(cpu_caps_t *res) {
res->cbitpos = ebx & 0x3f;
res->reduced_phys_bits = (ebx >> 6) & 0x3f;
+
+ unsigned int value;
+
+ if (read_msr(0x1401, &value) == 0) {
+ fprintf(stderr, "to read MSR: %08x \n", value);
+ res->tdx_support = (value & (1<<11));
+ } else {
+ fprintf(stderr, "Failed to read MSR\n");
+ }
}
int prepare_output_directory() {
@@ -82,13 +132,17 @@ int main() {
" \"sev-support\": %s,"
" \"sev-support-es\": %s,"
" \"sev-support-snp\": %s"
+ " },"
+ " \"intel-tdx\": {"
+ " \"tdx-support\": %s"
" }"
" }\n",
caps.cbitpos,
caps.reduced_phys_bits,
caps.sev_support ? "true" : "false",
caps.sev_es_support ? "true" : "false",
- caps.sev_snp_support ? "true" : "false"
+ caps.sev_snp_support ? "true" : "false",
+ caps.tdx_support ? "true" : "false"
);
if (ret < 0) {
eprintf("Error writing to file '" OUTPUT_PATH "': %s\n", strerror(errno));
diff --git a/src/usr/modules-load.conf b/src/usr/modules-load.conf
index aee7d42a..f45d256b 100644
--- a/src/usr/modules-load.conf
+++ b/src/usr/modules-load.conf
@@ -1 +1,2 @@
vhost_net
+msr
--
2.43.0
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-09-16 9:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-16 7:52 [pve-devel] [PATCH edk2-firmware/manager/qemu-server 0/8] Add support for Intel TDX Anton Iacobaeus
2025-09-16 7:52 ` [pve-devel] [PATCH edk2-firmware 1/4] Change name of SEV-related OVMF files Anton Iacobaeus
2025-09-16 9:48 ` Thomas Lamprecht
2025-09-16 7:52 ` [pve-devel] [PATCH edk2-firmware 2/4] Add firmware target for TDFV Anton Iacobaeus
2025-09-16 7:52 ` [pve-devel] [PATCH edk2-firmware 3/4] Add SCSI in NCCFV for TD guest Anton Iacobaeus
2025-09-16 7:52 ` [pve-devel] [PATCH edk2-firmware 4/4] Adapt APIC frequency " Anton Iacobaeus
2025-09-16 9:51 ` Thomas Lamprecht
2025-09-16 7:52 ` [pve-devel] [PATCH manager 1/1] Add support for Intel TDX Anton Iacobaeus
2025-09-16 7:52 ` [pve-devel] [PATCH qemu-server 1/3] Adapt AMD SEV code for compatibility with other platforms Anton Iacobaeus
2025-09-16 7:52 ` Anton Iacobaeus [this message]
2025-09-16 10:22 ` [pve-devel] [PATCH qemu-server 2/3] Add check for TDX support Thomas Lamprecht
2025-09-16 7:52 ` [pve-devel] [PATCH qemu-server 3/3] Add support for Intel TDX Anton Iacobaeus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250916075406.33084-10-anton.iacobaeus@canarybit.eu \
--to=anton.iacobaeus@canarybit.eu \
--cc=philipp.giersfeld@canarybit.eu \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox