[pve-devel] [PATCH network] sdn: remove unused function get_uplink_iface

* [pve-devel] [PATCH network] sdn: remove unused function get_uplink_iface
@ 2025-09-15  9:51 Gabriel Goller
  2025-09-16 10:10 ` [pve-devel] applied: " Thomas Lamprecht
  0 siblings, 1 reply; 2+ messages in thread
From: Gabriel Goller @ 2025-09-15  9:51 UTC (permalink / raw)
  To: pve-devel

Ripgrepped over all my local repos and didn't find an invocation. The
last invocation was removed with:
938ebef7bd73 ("vlan/qinq: use bridge option instead uplink-id").

Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
---
 src/PVE/Network/SDN/Zones/Plugin.pm | 25 -------------------------
 1 file changed, 25 deletions(-)

diff --git a/src/PVE/Network/SDN/Zones/Plugin.pm b/src/PVE/Network/SDN/Zones/Plugin.pm
index 0a977fd35a13..6dc2f655ffce 100644
--- a/src/PVE/Network/SDN/Zones/Plugin.pm
+++ b/src/PVE/Network/SDN/Zones/Plugin.pm
@@ -277,31 +277,6 @@ sub del_bridge_fdb {
 
 #helper
 
-sub get_uplink_iface {
-    my ($interfaces_config, $uplink) = @_;
-
-    my $iface = undef;
-    foreach my $id (keys %{ $interfaces_config->{ifaces} }) {
-        my $interface = $interfaces_config->{ifaces}->{$id};
-        if (my $iface_uplink = $interface->{'uplink-id'}) {
-            next if $iface_uplink ne $uplink;
-            if ($interface->{type} ne 'eth' && $interface->{type} ne 'bond') {
-                warn "uplink $uplink is not a physical or bond interface";
-                next;
-            }
-            $iface = $id;
-        }
-    }
-
-    #create a dummy uplink interface if no uplink found
-    if (!$iface) {
-        warn "can't find uplink $uplink in physical interface";
-        $iface = "uplink${uplink}";
-    }
-
-    return $iface;
-}
-
 sub get_local_route_ip {
     my ($targetip) = @_;
 
-- 
2.47.3



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


^ permalink raw reply	[flat|nested] 2+ messages in thread